Key Pair (angular) - don't sparkleOff when waiting for task #1178
Conversation
|
@tzumainn, can you, or someone from your group, please, review? Thx! |
|
@mansam, could you take a look? thanks! |
|
This seems to work, though it's still somewhat slow. The first attempt I made to create a keypair took about 60s to redirect, but subsequent requests only took about 15 seconds to complete. |
|
@mansam If you can investigate the slowness issue, feel free to take the BZ, I'm pretty sure that bit has nothing to do with UI.. |
|
@himdel The slowness isn't on the API side, as it only takes a second or so for the Openstack keypair operation to complete. Any other ideas about where the problem might be? |
|
Well, not really, no. I mean, I do know that creating the task returns almost immediately.. and then we wait. So.. backend :) but no idea where there, I've never seen the innards of the task queue.. |
|
This pull request is not mergeable. Please rebase and repush. |
|
Rebased after #719 - +added a whitespace cleanup to bring this in line with the rest. For fine, https://github.com/himdel/manageiq-ui-classic/commit/8e5d017bee4d1989e07017d32e058bd5beb055b9 ( |
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/27c0814be917a52d9c4fdb38914da9ec503c6c02~...da3ec4f9f6bde478eea464204f2a9a5728c201d2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@himdel Marking as |
|
@simaishi Makes sense, I've created https://bugzilla.redhat.com/show_bug.cgi?id=1462278 for this... |
|
..and created a fine PR: #1558 :) Thanks |
|
Backported to Fine via #1558 |
related to https://bugzilla.redhat.com/show_bug.cgi?id=1444520
Since #136, we're using the task queue for saving auth key pairs.
Which means the save request suceeds, disables sparkle, and then we wait for stuff to happen.
.. adding
{ complete: false }, in line with the rest of controllers using the task queue.https://bugzilla.redhat.com/show_bug.cgi?id=1462278