[FINE] Key Pair (angular) - don't sparkleOff when waiting for task #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/534a27e051a1b210d6045795956121c277371a15 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
mzazrivec
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fine version of #1178 - sparkle when waiting for task when saving a cloud key pair.
(The difference from the master PR is only in that #1178 got rebased on top of #719 and also fixes some resulting whitespace issues.)
master BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1462278
fine BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1462287