Convert vm_common controllers to use ControllerAs #1233

ZitaNemeckova · 2017-05-03T08:52:30Z

vmCloudAssociateFloatingIpFormController:
OpenStack Instance summary page -> Configuration -> Associate a Floating IP with this Instance

vmCloudDisassociateFloatingIpFormController:
OpenStack Instance summary page -> Configuration -> Disassociate a Floating IP with this Instance

vmCloudAttachFormController:
OpenStack Instance summary page -> Configuration -> Attach a Cloud Volume to this Instance

vmCloudDetachFormController:
OpenStack Instance summary page -> Configuration -> Detach a Cloud Volume to this Instance

vmCloudLiveMigrateFormController:
OpenStack Instance summary page -> Lifecycle -> Migrate selected Instance
vm_clouds_center_tb -> Lifecycle -> Migrate selected Instances

vmCloudEvacuateFormController:
OpenStack Instance summary page -> Lifecycle -> Evacuate selected Instance
vm_clouds_center_tb -> Lifecycle -> Evacuate selected Instances

vmCloudResizeFormController:
OpenStack Instance summary page -> Configuration -> Reconfigure this Instance
vm_clouds_center_tb -> Configuration -> Reconfigure this Instance

To have unless @explorer part of partial (vm_clouds_center_tb):
Compute -> Cloud -> Providers -> select OpenStack one -> in summary page select Instances/Vms -> select one or more Instances/VMs -> Lifecycle -> etc...

@miq-bot add_label angular dialogs, technical debt, wip

https://www.pivotaltracker.com/story/show/143026077
https://www.pivotaltracker.com/story/show/143026061
https://www.pivotaltracker.com/story/show/143026049
https://www.pivotaltracker.com/story/show/143026033
https://www.pivotaltracker.com/story/show/143026085

TODO:

miq-bot · 2017-05-03T08:53:06Z

@ZitaNemeckova Cannot apply the following label because they are not recognized: angular_dialogs

ZitaNemeckova · 2017-05-04T11:55:03Z

@miq-bot add_label angular dialogs

ZitaNemeckova · 2017-06-09T12:19:42Z

@miq-bot remove_label wip

ZitaNemeckova · 2017-06-14T11:36:37Z

@lgalis please review, thanks :)

lgalis · 2017-06-14T16:16:10Z

@ZitaNemeckova - this is what I see when selecting Cloud->Providers->Rellationshhips->Instances-> LiveMigrate for an instance
( Look at the buttons, I know the list of instances is a GTL issue - I have a separate GH issue opened for that). I see the same for Evacuate.
Update - I see the same issue for the buttons when I check an instance in Cloud->Instances _>Live Migrate or Evacuate ( but there is an additional error there for the ReportData Controller, unrelated to your changes).

himdel · 2017-06-22T11:21:17Z

app/assets/javascripts/controllers/vm_cloud/vm_cloud_associate_floating_ip_form_controller.js

-  $scope.modelCopy = angular.copy( $scope.vmCloudModel );
+  vm.floating_ips = [];
+  vm.formId = vmCloudAssociateFloatingIpFormId;
+  vm.modelCopy = angular.copy( vm.vmCloudModel );

  ManageIQ.angular.scope = $scope;


himdel · 2017-06-22T11:21:25Z

app/assets/javascripts/controllers/vm_cloud/vm_cloud_attach_form_controller.js

+  vm.vmCloudModel = { name: '' };
+  vm.formId = vmCloudAttachFormId;
+  vm.afterGet = false;
+  vm.modelCopy = angular.copy( vm.vmCloudModel );

  ManageIQ.angular.scope = $scope;


himdel · 2017-06-22T11:21:59Z

app/assets/javascripts/controllers/vm_cloud/vm_cloud_live_migrate_form_controller.js

+  vm.hosts = [];
+  vm.filtered_hosts = [];
+  vm.formId = vmCloudLiveMigrateFormId;
+  vm.modelCopy = angular.copy(vm.vmCloudModel);

  ManageIQ.angular.scope = $scope;


himdel · 2017-06-22T11:23:06Z

.. and you should no longer have to inject $scope in any of those controllers if I'm seeing correctly ;).

himdel · 2017-06-22T12:26:28Z

The checklist..

EDIT: moved to the PR description

ZitaNemeckova · 2017-06-23T09:53:29Z

@miq-bot add_label wip

himdel · 2017-08-07T13:16:40Z

app/views/vm_common/_disassociate_floating_ip.html.haml


-  %div_for_paging{'ng-controller'                    => "pagingDivButtonGroupController",
-                  'paging_div_buttons_id'            => "angular_paging_div_buttons",
-                  'paging_div_buttons_type'          => "Submit"}

 - unless @explorer


This is definitely broken .. looks like you had to move this right in associate, so that the buttons are part of the form .. but forgot to do the same here?

Also, submitClicked() and cancelClicked() look suspiciously vm-less ;)

Well, %div_for_paging is used elsewhere and it has vm-less submitClicked() and cancelClicked() so I left them to be on $scope for now.

himdel · 2017-08-07T13:20:33Z

app/views/vm_common/_attach.html.haml

-                            :miqrequired   => false,
-                            :checkchange   => true}
+                            'ng-model'     => "vm.vmCloudModel.device_path",
+                            'ng-maxlength' => 128}


This should be maxlength, 128 is a valid expression, but no need to use the ng- version with a constant...

himdel · 2017-08-07T13:21:37Z

app/views/vm_common/_attach.html.haml

+                            'ng-model'     => "vm.vmCloudModel.device_path",
+                            'ng-maxlength' => 128}
+
+    %div_for_paging{'ng-controller'                    => "pagingDivButtonGroupController",


Was this moved inside form-horizontal on purpose?

himdel · 2017-08-07T13:21:59Z

app/views/vm_common/_detach.html.haml

-  %div_for_paging{'ng-controller'                    => "pagingDivButtonGroupController",
-                  'paging_div_buttons_id'            => "angular_paging_div_buttons",
-                  'paging_div_buttons_type'          => "Submit"}
+    %div_for_paging{'ng-controller'                    => "pagingDivButtonGroupController",


himdel · 2017-08-18T14:20:23Z

app/views/vm_common/_disassociate_floating_ip.html.haml


  %div_for_paging{'ng-controller'                    => "pagingDivButtonGroupController",
                  'paging_div_buttons_id'            => "angular_paging_div_buttons",
                  'paging_div_buttons_type'          => "Submit"}

+
 - unless @explorer


You want to move this to the right too, otherwise it's not part of the form and can't access the controller..

himdel · 2017-08-18T14:40:55Z

himdel · 2017-08-30T14:26:10Z

app/views/vm_common/_live_migrate.html.haml

@@ -45,8 +47,8 @@
          = _('Destination Host')
        .col-md-8
          %select{:name      => 'destination_host_id',
-                  'ng-model' => 'vmCloudModel.host',
-                  'ng-options' => 'host.name as host.name for host in hosts track by host.id'}
+                  'ng-model' => 'vm.mCloudModel.host',


Typo - mCloudModel should be vmCloudModel

If you have trouble testing this...

--- a/app/controllers/mixins/actions/vm_actions/live_migrate.rb +++ b/app/controllers/mixins/actions/vm_actions/live_migrate.rb @@ -50,6 +50,10 @@ module Mixins hosts = [] end end + hosts = [ + {:name => "Karel", :id => 21}, + {:name => "Lojza", :id => 123}, + ] render :json => { :hosts => hosts }

…l, true)

miq-bot · 2017-09-01T11:43:54Z

Checked commits ZitaNemeckova/manageiq-ui-classic@3596313~...8ba980d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

app/controllers/mixins/actions/vm_actions/disassociate_floating_ip.rb

❗ - Line 79, Col 20 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

miq-bot changed the title ~~Convert associate_floating_ip to use ControllerAs~~ [WIP] Convert associate_floating_ip to use ControllerAs May 3, 2017

miq-bot added technical debt wip labels May 3, 2017

ZitaNemeckova changed the title ~~[WIP] Convert associate_floating_ip to use ControllerAs~~ [WIP] Convert vm_common controllers to use ControllerAs May 3, 2017

miq-bot added the angular dialogs label May 4, 2017

ZitaNemeckova force-pushed the controllerAs_associate_floating_ip branch from aeeb4d3 to 00ddbab Compare May 10, 2017 08:52

ZitaNemeckova force-pushed the controllerAs_associate_floating_ip branch from 00ddbab to d07261b Compare June 9, 2017 11:40

miq-bot changed the title ~~[WIP] Convert vm_common controllers to use ControllerAs~~ Convert vm_common controllers to use ControllerAs Jun 9, 2017

miq-bot removed the wip label Jun 9, 2017

dclarizio added the fine/no label Jun 21, 2017

dclarizio assigned himdel Jun 21, 2017

himdel reviewed Jun 22, 2017

View reviewed changes

miq-bot changed the title ~~Convert vm_common controllers to use ControllerAs~~ [WIP] Convert vm_common controllers to use ControllerAs Jun 23, 2017

miq-bot added the wip label Jun 23, 2017

ZitaNemeckova force-pushed the controllerAs_associate_floating_ip branch 3 times, most recently from 12d32f4 to 1fc2b79 Compare June 27, 2017 14:21

ZitaNemeckova mentioned this pull request Jul 12, 2017

Fix Evacuate form #1676

Merged

ZitaNemeckova force-pushed the controllerAs_associate_floating_ip branch from 1fc2b79 to 7c4f9ba Compare July 12, 2017 11:21

ZitaNemeckova closed this Jul 13, 2017

himdel reviewed Aug 7, 2017

View reviewed changes

ZitaNemeckova force-pushed the controllerAs_associate_floating_ip branch from c3b0a75 to 7c8250e Compare August 7, 2017 14:15

ZitaNemeckova closed this Aug 11, 2017

ZitaNemeckova reopened this Aug 11, 2017

himdel reviewed Aug 18, 2017

View reviewed changes

himdel reviewed Aug 30, 2017

View reviewed changes

ZitaNemeckova added 12 commits August 31, 2017 14:04

Convert associate_floating_ip to use ControllerAs

3596313

Convert attach and detach to use ControllerAs

b0d229a

Convert disassociate_floating_ip to use ControllerAs

f23816f

Covert evacuate to use controllerAs

7301a04

Convert live_migrate to use controllerAs

22ff1a6

Change buttons in resize to paging_group_buttons

1c8819a

Fix vm = this; to var vm = this;

14a7be9

Add specs for vm_cloud controllers

7b049c5

Remove scope, setPristine, use Object.assign, remove miqAjaxButton(ur…

ee36990

…l, true)

Fix buttons

c36b35d

Fix Cancel button for Disassociate a Floating IP

d451a40

Address reviews

ee467b6

ZitaNemeckova force-pushed the controllerAs_associate_floating_ip branch 2 times, most recently from 034afb9 to bbc703a Compare September 1, 2017 09:39

Remove unused code under unless @explorer

8ba980d

ZitaNemeckova force-pushed the controllerAs_associate_floating_ip branch from bbc703a to 8ba980d Compare September 1, 2017 11:42

himdel merged commit 04cbe32 into ManageIQ:master Sep 1, 2017

himdel added this to the Sprint 68 Ending Sep 4, 2017 milestone Sep 1, 2017

ZitaNemeckova deleted the controllerAs_associate_floating_ip branch September 12, 2017 14:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert vm_common controllers to use ControllerAs #1233

Convert vm_common controllers to use ControllerAs #1233

ZitaNemeckova commented May 3, 2017 •

edited by himdel

miq-bot commented May 3, 2017

ZitaNemeckova commented May 4, 2017

ZitaNemeckova commented Jun 9, 2017

ZitaNemeckova commented Jun 14, 2017

lgalis commented Jun 14, 2017 •

edited

himdel Jun 22, 2017

himdel Jun 22, 2017

himdel Jun 22, 2017

himdel commented Jun 22, 2017

himdel commented Jun 22, 2017 •

edited

ZitaNemeckova commented Jun 23, 2017

himdel Aug 7, 2017

himdel Aug 7, 2017

ZitaNemeckova Aug 7, 2017

himdel Aug 7, 2017

himdel Aug 7, 2017

himdel Aug 7, 2017

himdel Aug 18, 2017

himdel commented Aug 18, 2017 •

edited

himdel Aug 30, 2017

himdel Aug 30, 2017

miq-bot commented Sep 1, 2017

Convert vm_common controllers to use ControllerAs #1233

Convert vm_common controllers to use ControllerAs #1233

Conversation

ZitaNemeckova commented May 3, 2017 • edited by himdel

miq-bot commented May 3, 2017

ZitaNemeckova commented May 4, 2017

ZitaNemeckova commented Jun 9, 2017

ZitaNemeckova commented Jun 14, 2017

lgalis commented Jun 14, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

himdel commented Jun 22, 2017

himdel commented Jun 22, 2017 • edited

ZitaNemeckova commented Jun 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

himdel commented Aug 18, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miq-bot commented Sep 1, 2017

ZitaNemeckova commented May 3, 2017 •

edited by himdel

lgalis commented Jun 14, 2017 •

edited

himdel commented Jun 22, 2017 •

edited

himdel commented Aug 18, 2017 •

edited