Fix Evacuate form

[ZitaNemeckova]

Where:
Compute -> Clouds -> Instances -> click OpenStack one -> Lifecycle -> Evacuate Instance
Compute -> Clouds -> Instances -> check OpenStack one or more -> Lifecycle -> Evacuate Instance
Compute -> Clouds -> Providers -> click OpenStack one -> click Instances-> click one -> Lifecycle -> Evacuate Instance
Compute -> Clouds -> Providers -> click OpenStack one -> click Instances-> check one or more -> Lifecycle -> Evacuate Instance

Before:
Various error message on screen or in log. Like undefined method 'length' for nil:NilClass [vm/evacuate] or Error caught: [RuntimeError] Can't access selected records. Never displaying Evacuate form.

After:
It works :) With GTL issue that's not related to this PR. User can get to form for Evacuate and can save or cancel it.

Blockes #1233

@miq-bot add_label bug

@romanblanco please have a look as it's related to RBAC

[romanblanco]

@miq-bot assign @romanblanco

[romanblanco]

@ZitaNemeckova It works better, but I'm still getting Javascript error message:

Error: [$controller:ctrlreg] The controller with the name 'reportDataController' is not registered.
http://errors.angularjs.org/1.6.5/$controller/ctrlreg?p0=reportDataController

[himdel]

@romanblanco The reportDataController problem is unrelated, that happen sometimes on every screen with a sub-GTL, @karelhala is aware of it..

But I'm more concerned with what the screengrab seems to be saying...

You are on an instance detail screen, click evacuate, and suddenly the list contains 6 instances. That is definitely not desired ;)

[karelhala]

The controller with the name 'reportDataController' is not registered. happens because you register gtl controller too late. Can you @ZitaNemeckova add = render :partial => "layouts/gtl" to the bottom of page above :javascript? This should fix the issue. However another issue which @himdel mentioned seemes kinda fishy. I will have to investigate further to see what causes this problem.

[ZitaNemeckova]

@karelhala Thanks it really helped :)

[romanblanco]

@karelhala @ZitaNemeckova Moving render before :javascript didn't help, I'm still seeing the error, but I checked with @himdel and the issue is unrelated to the fix in this PR.

Changes in PR are fixing the original error correctly 👍

[miq-bot]

Checked commits ZitaNemeckova/manageiq-ui-classic@af3e468~...28373ff with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

[himdel]

Tested in the UI, works in both the explorer view and non-explorer, for one or multiple instances.

There are still multiple GTL issues on that screen - created #1715 - but evacuating works 👍