Clickable labels in policy's event assignment screen #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit mzazrivec@773fccf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/views/miq_policy/_policy_details.html.haml
|
|
@mzazrivec can you add a screenshot please? Thx, Dan |
|
@dclarizio Screenshots added. |
|
Backported to Fine to avoid conflict backporting #1543. The change made in this PR is re-done in #1543 and will not change the outcome. |
simaishi
pushed a commit
that referenced
this pull request
Jun 15, 2017
…ent_assignment_screen Clickable labels in policy's event assignment screen (cherry picked from commit 4351809)
mzazrivec
deleted the
clickable_labels_in_policy_event_assignment_screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control -> Explorer -> Policies -> [policy] -> Edit policy's event assignment: clicking on event label
would check / uncheck the checkbox as well.
Before, the checkbox labels weren't clickable:
After, the checkbox labels are clickable (not really visible from the screenshot):
https://bugzilla.redhat.com/show_bug.cgi?id=1459496