Container project dashboard view #1527

zeari · 2017-06-12T12:45:20Z

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1461618
Dashboard view for container projects
with data:

with no data available:

@serenamarie125 @Loicavenel @simon3z

correct pod statistics depend on: ManageIQ/manageiq#10470

zeari · 2017-06-12T12:46:39Z

@miq-bot add_label compute/containers, wip

Loicavenel · 2017-06-13T01:56:06Z

@zeari Thanks for sharing. There are other things we should look at:

Some Performance Charts: CPU and Memory graph over last 30 days
List of all Pods and their status: I can image a table with 2 columns Pod Name and Status.

@serenamarie125 We need a better presentation here especially if we add the suggestion above

simon3z · 2017-07-07T16:15:46Z

cc @dclarizio

zeari · 2017-08-17T12:15:45Z

~~@Loicavenel @simon3z @serenamarie125, This is the design im currently going with:~~
~~[old screenshot]~~

Some Performance Charts: CPU and Memory graph over last 30 days
List of all Pods and their status: I can image a table with 2 columns Pod Name and Status.

this generally covers your request as well as show quotas. Can anyone softly ack this design so i can proceed?

serenamarie125 · 2017-08-17T12:43:06Z

@zeari yes definitely in the right direction!

Here is the layout I initially provided:

Aggregate status cards should definitely be on the top.
The layout of the trend card which i used is a bit different from PatternFly, and we will be contributing it to Ang-PF this month or early September. I would try using "Card with Single Trend" from http://www.patternfly.org/angular-patternfly/#/api/patternfly.card.component:pfCard%20-%20Trends ... and we will then be adding a mechanism to have the text on the right.

Hope that helps!

Loicavenel · 2017-08-20T14:56:16Z

@zeari I really like it.. this will look great..

Loicavenel · 2017-08-21T16:59:35Z

@zeari can you clarify the Limits is CPU while graph is Cores... We see CPU limits to 2 but 4 Cores.. so, CPU are multiple-cores?

zeari · 2017-08-22T09:26:03Z

@zeari can you clarify the Limits is CPU while graph is Cores... We see CPU limits to 2 but 4 Cores.. so, CPU are multiple-cores?

I put in some random metrics instead of waiting for them to generate. Ill make sure this doesnt happen normally.

zeari · 2017-08-22T11:06:00Z

@yaacov @zakiva Please review.

zeari · 2017-08-22T11:17:50Z

spec/controllers/container_project_controller_spec.rb

@@ -19,7 +19,7 @@
    expect(response.body).to_not be_empty
    expect(assigns(:breadcrumbs)).to eq([{:name => "Projects",
                                          :url  => "/container_project/show_list?page=&refresh=y"},
-                                         {:name => "Test Project (Summary)",
+                                         {:name => "Test Project (Dashboard)",


Since dashboard is the default view

zeari · 2017-08-22T12:05:50Z

@miq-bot remove_label wip

dclarizio · 2017-08-22T13:44:05Z

@h-kataria can you help @zeari make sure this is following the new direction we have for the PF dashboards? Give some direction if needed.

@zeari I haven't looked at the codeclimate issues, but 80 is quite high. Can you please take a look to see if that can be knocked down?

Thx, Dan

zeari · 2017-08-22T13:47:18Z

@zeari I haven't looked at the codeclimate issues, but 80 is quite high. Can you please take a look to see if that can be knocked down?

mostly code duplication. Ill try to throw what i can into a mixin.

serenamarie125 · 2017-08-22T20:08:59Z

@zeari this looks great! Thanks for updating to match the mocks !

serenamarie125

LGTM!

serenamarie125 · 2017-08-22T20:10:54Z

@miq-bot add_label ux/approved

simon3z · 2017-08-23T08:52:57Z

LGTM 👍
cc @dclarizio

dclarizio · 2017-08-23T13:49:57Z

@zeari I haven't looked at the codeclimate issues, but 80 is quite high. Can you please take a look to see if that can be knocked down?

mostly code duplication. Ill try to throw what i can into a mixin.

I see a bunch of syntax checks as well . . . @himdel can you recommend which cc issues we can overlook and which should be taken care of?

h-kataria

Generally this looks good, but @zeari we will need to convert these into Angular and to consume API endpoints(wherever possible) once we have #1901 completed/merged.

h-kataria · 2017-08-23T14:01:44Z

@zeari if you can knock down some of the code climate warnings that will be good.

himdel · 2017-08-25T13:22:01Z

@zeari Look at https://codeclimate.com/github/ManageIQ/manageiq-ui-classic/pull/1527 please.

Looks like that service is just a copy of the original one, with very little changes, please try to add a mixin to avoid copy-pasting :)

EDIT: oh, Harpreet already mentioned it :)

miq-bot · 2017-08-28T11:28:51Z

Checked commits zeari/manageiq-ui-classic@41e6a99~...feffdde with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
9 files checked, 1 offense detected

spec/controllers/container_project_controller_spec.rb

❗ - Line 33, Col 15 - Rails/HttpPositionalArguments - Use keyword arguments instead of positional arguments for http call: get.

zeari · 2017-08-28T12:02:30Z

Looks like that service is just a copy of the original one, with very little changes, please try to add a mixin to avoid copy-pasting :)

Moved to ContainerServiceMixin.

himdel · 2017-08-29T12:22:18Z

@zeari ~~Sorry, but the same goes for the JS bits..~~ container_dashboard_controller.js and container_project_dashboard_controller.js ~~are exactly the same code,~~

^ this is a problem, but it's one I don't want to block this on since we already have the exact same thing for ems_infra_dashboard_controller.js.

@h-kataria @AparnaKarve @zeari We can't afford to have multiple dashboard controllers, each doing the exactly same thing, on a bit different set of entities. This is topology all over again (where the count is now 6 copies, not 3).

Will one of you take care of merging those 3 dashboard controllers back into one or should I take it?

himdel · 2017-08-29T12:23:40Z

Tested in the UI, both the container dashboard and the project dashboard seem to work.

h-kataria · 2017-10-17T20:51:19Z

@zeari now that #1901 is merged, i think you can go-ahead and convert Container Project dashboard to follow the same pattern. Feel free to ping me if you have questions

miq-bot added compute/containers wip labels Jun 12, 2017

zeari mentioned this pull request Jun 12, 2017

Add container groups\images statistics for container projects ManageIQ/manageiq#10470

Merged

zeari force-pushed the projects_dashboard branch 2 times, most recently from ab5dce5 to f05b314 Compare June 12, 2017 13:32

zeari force-pushed the projects_dashboard branch 2 times, most recently from c516519 to 7a47fdb Compare June 19, 2017 10:22

dclarizio added the enhancement label Jul 7, 2017

zeari force-pushed the projects_dashboard branch 3 times, most recently from 15ffbb2 to 3bcd089 Compare August 21, 2017 14:38

zeari force-pushed the projects_dashboard branch 2 times, most recently from 8758222 to f157c00 Compare August 22, 2017 11:05

zeari force-pushed the projects_dashboard branch 2 times, most recently from eea20d7 to 56852ee Compare August 22, 2017 11:15

zeari commented Aug 22, 2017

View reviewed changes

zeari force-pushed the projects_dashboard branch from 56852ee to 3f75a3b Compare August 22, 2017 12:04

miq-bot changed the title ~~[WIP] Container project dashboard view~~ Container project dashboard view Aug 22, 2017

miq-bot removed the wip label Aug 22, 2017

zeari force-pushed the projects_dashboard branch from 3f75a3b to 30db206 Compare August 22, 2017 13:38

dclarizio requested a review from h-kataria August 22, 2017 13:41

dclarizio self-assigned this Aug 22, 2017

serenamarie125 approved these changes Aug 22, 2017

View reviewed changes

miq-bot added the ux/approved label Aug 22, 2017

dclarizio requested a review from himdel August 23, 2017 13:48

h-kataria approved these changes Aug 23, 2017

View reviewed changes

zeari force-pushed the projects_dashboard branch from 30db206 to 67da578 Compare August 24, 2017 11:59

zeari force-pushed the projects_dashboard branch 2 times, most recently from 1fff023 to a8dfa11 Compare August 28, 2017 10:33

Ari Zellner added 2 commits August 28, 2017 14:04

Container project dashboard view

41e6a99

refactor container dashboard code to mixin

feffdde

zeari force-pushed the projects_dashboard branch from a8dfa11 to feffdde Compare August 28, 2017 11:27

himdel merged commit 6d9a40a into ManageIQ:master Aug 29, 2017

This was referenced Aug 31, 2017

fix container projects dashboard metrics and container view #2065

Merged

Refactor data fetching from angular dashboard controllers #2066

Merged

chessbyte added this to the Sprint 68 Ending Sep 4, 2017 milestone Oct 16, 2017

himdel mentioned this pull request Jul 7, 2020

Utilization/Trends are shown on the container provider level but not on the projects level #7186

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Container project dashboard view #1527

Container project dashboard view #1527

zeari commented Jun 12, 2017 •

edited

Loading

zeari commented Jun 12, 2017

Loicavenel commented Jun 13, 2017

simon3z commented Jul 7, 2017

zeari commented Aug 17, 2017 •

edited

Loading

serenamarie125 commented Aug 17, 2017

Loicavenel commented Aug 20, 2017

Loicavenel commented Aug 21, 2017

zeari commented Aug 22, 2017

zeari commented Aug 22, 2017

zeari Aug 22, 2017

zeari commented Aug 22, 2017

dclarizio commented Aug 22, 2017

zeari commented Aug 22, 2017

serenamarie125 commented Aug 22, 2017

serenamarie125 left a comment

serenamarie125 commented Aug 22, 2017

simon3z commented Aug 23, 2017

dclarizio commented Aug 23, 2017

h-kataria left a comment

h-kataria commented Aug 23, 2017

himdel commented Aug 25, 2017 •

edited

Loading

miq-bot commented Aug 28, 2017

zeari commented Aug 28, 2017

himdel commented Aug 29, 2017 •

edited

Loading

himdel commented Aug 29, 2017

h-kataria commented Oct 17, 2017

Container project dashboard view #1527

Container project dashboard view #1527

Conversation

zeari commented Jun 12, 2017 • edited Loading

zeari commented Jun 12, 2017

Loicavenel commented Jun 13, 2017

simon3z commented Jul 7, 2017

zeari commented Aug 17, 2017 • edited Loading

serenamarie125 commented Aug 17, 2017

Loicavenel commented Aug 20, 2017

Loicavenel commented Aug 21, 2017

zeari commented Aug 22, 2017

zeari commented Aug 22, 2017

zeari Aug 22, 2017

Choose a reason for hiding this comment

zeari commented Aug 22, 2017

dclarizio commented Aug 22, 2017

zeari commented Aug 22, 2017

serenamarie125 commented Aug 22, 2017

serenamarie125 left a comment

Choose a reason for hiding this comment

serenamarie125 commented Aug 22, 2017

simon3z commented Aug 23, 2017

dclarizio commented Aug 23, 2017

h-kataria left a comment

Choose a reason for hiding this comment

h-kataria commented Aug 23, 2017

himdel commented Aug 25, 2017 • edited Loading

miq-bot commented Aug 28, 2017

zeari commented Aug 28, 2017

himdel commented Aug 29, 2017 • edited Loading

himdel commented Aug 29, 2017

h-kataria commented Oct 17, 2017

zeari commented Jun 12, 2017 •

edited

Loading

zeari commented Aug 17, 2017 •

edited

Loading

himdel commented Aug 25, 2017 •

edited

Loading

himdel commented Aug 29, 2017 •

edited

Loading