Set Field value to a blank value to avoid crashes due to a nil value #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label fine/yes,bug,expressions/filters |
|
Checked commit AparnaKarve@1bee4d2 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
Aug 4, 2017
…valid_value Set Field value to a blank value to avoid crashes due to a nil value (cherry picked from commit ae3741a) https://bugzilla.redhat.com/show_bug.cgi?id=1478409
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expressions with field values of type
Textmust contain a blank string at the start in order to prevent crashes when a user clicks on the check mark mid-way before the expression is fully formed.https://bugzilla.redhat.com/show_bug.cgi?id=1466778
To reproduce the issue (the crash), select
Build Stateas the field value in the Provider Foreman Advanced Search Expression editor. Click on the check mark button without entering a value.