[FINE] Fix choose Provider reset bug

[gildub]

Fixes unexpected error message while adding new Cloud Subnet:

https://bugzilla.redhat.com/show_bug.cgi?id=1490416

[martinpovolny]

if (id) {
  return;
}

maybe? given the whole function body is under the condition and we love to limit nesting?

[AparnaKarve]

@gildub I also recommend using -

options_for_select([["<#{_('Choose')}>", nil]] + @network_provider_choices.sort, disabled: ["<#{_('Choose')}>", nil]),

So that the user is forced to make a valid selection and cannot choose <Choose>
This change alone should help address the BZ, and you probably don't even need the other changes.

[gildub]

@AparnaKarve, I was trying to align with the code on master branch but you're right that's better. Thanks

[gildub]

@martinpovolny, yes that sounds more solid, meanwhile for this BZ @AparnaKarve suggestion would do. Thanks

[simaishi]

@AparnaKarve Is this good to go?

[AparnaKarve]

@simaishi Yes, this is good to go.
Thanks.

[simaishi]

Oh no, there is a conflict now... @gildub please resolve the conflict. Thanks!

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[gildub]

@simaishi, conflict resolved.

[miq-bot]

Checked commits https://github.com/gildub/manageiq-ui-classic/compare/9083d1e0d123d52880ac53499def5cb4586a197f~...714162f54997f2dcc33488b797acea9e2a28ff55 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

[himdel]

This PR introduces several bugs... the controller is using controllerAs even in fine, but this backport isn't.

 +                      "ng-model"                    => "cloudSubnetModel.ems_id",

should be vm.cloudSubnetModel.ems_id.

 +                      "ng-change"                   => "filterNetworkManagerChanged(cloudSubnetModel.ems_id)",

should be vm.filterNetworkManagerChanged(vm.cloudSubnetModel.ems_id) (vm twice).

EDIT: fixed by #3254