[FINE] Corrects model and function names in New Subnet form #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug,blocker,fine/yes |
|
Checked commit https://github.com/petrblaho/manageiq-ui-classic/commit/6cbed30f3e11a82c02c41297543e640b5a5c25d0 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
The code for newer branches is already there - https://github.com/ManageIQ/manageiq-ui-classic/pull/1545/files#diff-338ecb79799bff25e172f8849a48dbbd |
|
@himdel, can you or anyone can look at this, please? |
himdel
changed the title
|
LGTM, fixes #2301 (comment), thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves https://bugzilla.redhat.com/show_bug.cgi?id=1533011
Steps for Testing/QA [taken from BZ linked above]
Steps to Reproduce:
Results without patch:
Page is corrupted, network dropdown is missing
Results with patch (expected):
Network drop-down should be present on the page