[WIP] Topology - unify and deduplicate entity_status #2355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass in addition to text Right now, the visual class is being computed by TopologyService.getItemStatusClass in js, based on the string from the server. This does not work if the string is translated - no i18n for statuses or no visual class. This makes all topology services use entity_status (Middleware didn't), and set it via set_entity_status, providing the class when available. It does not remove the JS logic yet, since these values can also come from the DB.
* always use case * don't repeat "Unknown" for every other condition - settle on `nil` meaning Unknown * use default authentication status for all managers, not the first authentication (and use ExtManagementSystem instead of listing each kind) * prefer `x.try(:capitalize)` over `x ? x.capitalize : "Unknown"` and `x.capitalize if x` * prefer `x.foo if x` over `x ? x.foo : "Unknown"` * move all entity types mentioned in multiple topologies to TopologyService
this makes us set `:status => _('OK'), :status_class => 'success'` instead of just `:status => 'OK'` for all the statuses which were a string constant
this does not attempt to read DB data
so we can actually try to translate the strings after determining the class
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/bff73544fa3100da9fabd9039d6484c5e1c8845e~...942c2230fab1525df7abeb702ac226dc7042c031 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 app/services/topology_service.rb
|
|
This pull request is not mergeable. Please rebase and repush. |
|
This pull request has been automatically closed because it has not been updated for at least 6 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip
(should be done - todo extract desc from commits & test)