Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reload button should use the current display value #2419

Merged
merged 2 commits into from Nov 15, 2017
Merged

Reload button should use the current display value #2419

merged 2 commits into from Nov 15, 2017

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Oct 16, 2017

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1493134

Steps for Testing/QA

Steps to Reproduce:

  1. Enable Embedded Ansible
  2. Add repository with playbooks and wait for refresh to complete
  3. Click on repo
  4. Click on Playbooks row in the Relationships table
  5. Click on Reload button

@lgalis lgalis changed the title [WIP] Reload button should use the current @display [WIP] Reload button should use the current display value Oct 16, 2017
@miq-bot miq-bot added the wip label Oct 16, 2017
@lgalis lgalis force-pushed the reload_repository_playbook_list branch from 7e8d469 to 6b1b2af Compare November 9, 2017 15:09
@lgalis lgalis force-pushed the reload_repository_playbook_list branch from 6b1b2af to 8107a00 Compare November 9, 2017 15:48
@miq-bot
Copy link
Member

miq-bot commented Nov 9, 2017

Checked commits lgalis/manageiq-ui-classic@8107a00~...4f72ef3 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@lgalis
Copy link
Contributor Author

lgalis commented Nov 9, 2017

@miq-bot add_label bug, gaprindashvili/yes

@lgalis lgalis changed the title [WIP] Reload button should use the current display value Reload button should use the current display value Nov 9, 2017
@miq-bot miq-bot removed the wip label Nov 9, 2017
@mzazrivec mzazrivec self-assigned this Nov 15, 2017
@mzazrivec mzazrivec added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 15, 2017
@mzazrivec mzazrivec merged commit 80f03c7 into ManageIQ:master Nov 15, 2017
simaishi pushed a commit that referenced this pull request Nov 15, 2017
@mzazrivec @simaishi
Merge pull request #2419 from lgalis/reload_repository_playbook_list
cabf2cc 
Reload button should use the current display value
(cherry picked from commit 80f03c7)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit cabf2ccb620597e01bfa5cd0f71b9112bd7da865
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Nov 15 13:48:22 2017 +0100

    Merge pull request #2419 from lgalis/reload_repository_playbook_list
    
    Reload button should use the current display value
    (cherry picked from commit 80f03c7ab19b94a3f988d1dca4b5348fb68ebf6d)

@lgalis lgalis deleted the reload_repository_playbook_list branch November 15, 2017 18:31
This was referenced Jun 19, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
automation/ansible bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lgalis @miq-bot @simaishi @mzazrivec