New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused Ansible Repository page refresh #4163
Remove unused Ansible Repository page refresh #4163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but I need to test it. I will let you know asap. Anyway, I would add this #2419 here just for info/explanation how params[:display] = @display if @display
was added there some time ago. The problem there was that wrong toolbar was chosen while displaying nested list of playbooks - and this is why Refresh button was there (but did not work well, of course, and so there was effort to fix it - to make the button work).
So it looks ok to me and it works. @skateman could you check the changes for the tests, please? :) Thank you! |
Test changes are just deletions, seems okay, but travis is failing 😞 |
The failures and errors are from different specs and are unrelated. I can try rebasing if it helps. |
The refresh page button is no longer present on Ansible Repository Playbooks subpage. Because of that it is no longer necessary to handle pressing this button on this subpage. Remove this handling and related spec examples.
724ddde
to
fafd853
Compare
Checked commit Glutexo@fafd853 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
I believe that at least here I am innocent. Travis is failing because of yarn timeout. |
@Glutexo probably yes, I will try something 😉 |
Just wondering, if the [technical-debt] flag means that the PR reduces the debt or increases it. 😅 |
@Glutexo It means it reduces the tech. debt. |
The refresh page button is no longer present on Ansible Repository Playbooks subpage. Because of that it is no longer necessary to handle pressing this button on this subpage. Remove this handling and related spec examples.
Steps to reproduce:
Now,
manageiq-ui-classic/app/controllers/ansible_repository_controller.rb
Line 43 in 2985663
Fixes #4160. Helps #3762.
@miq-bot add_reviewer @hstastna