Add scopes selector for MiqTasks

[tumido]

Copy the tasks_condition behavior, but return :named_scopes instead of :conditions.

In future replace the tasks_condition method, when possible.

Depends on: ManageIQ/manageiq/pull/16308, ManageIQ/manageiq#16323
Should help with: #2383

[tumido]

cc @martinpovolny

[skateman]

You can and should use reduce here.

[tumido]

@skateman, sure I will, give me 1 hour. :P

[martinpovolny]

@skateman, @mzazrivec, @tumido : tested? working?

rspec ./spec/controllers/miq_task_controller_spec.rb:827 # MiqTaskController#tasks_condition #list_jobs sets the active tab

Looks related :-(

[martinpovolny]

@skateman : otherwise tested, reviewed?

[skateman]

@tumido I was wrapping my head around this and I understand it more or less, but I think this would need some extra description above the method and some specs. I was also clicking through the UI and found out that the filtering doesn't work at all with your changes 😞

It seems like the tasks_scopes(@tasks_options[@tabform]) always returns nil

[skateman]

☠️ ☠️ ☠️ 🚒 🚽

[tumido]

Newly depends on ManageIQ/manageiq#16323

[tumido]

Since we can't effectively build scoped queried for state and status attributes, this functionality has been removed. For now, the data returned are not filtered based on state or status. The problem we're facing here is that the original query looks like

["miq_tasks.userid=? AND ((miq_tasks.state=? OR miq_tasks.state=?) OR (miq_tasks.state=? AND miq_tasks.status=?) OR (miq_tasks.state=? AND miq_tasks.status=?) OR (miq_tasks.state=? AND miq_tasks.status=?) OR (miq_tasks.state!=? AND miq_tasks.state!=? AND miq_tasks.state!=?)) AND miq_tasks.updated_on>=? AND miq_tasks.updated_on<=?",
 "admin",
 "Waiting_to_start",
 "Queued",
 "Finished",
 "Ok",
 "Finished",
 "Error",
 "Finished",
 "Warn",
 "Finished",
 "Waiting_to_start",
 "Queued",
 Fri, 27 Oct 2017 00:00:00 UTC +00:00,
 Fri, 27 Oct 2017 23:59:59 UTC +00:00]

If you look closely you can see we have here ANDed queries for userid, <state and status>, updated_on. And the <state and status> has mix of ORs and ANDs inside. Which is pain for scopes. I can't find a way how to do it properly now, so this filtering is avoided for now.

[abonas]

what is the status of this PR? is it needed for the upcoming release?

[tumido]

@abonas, yes. But not by our team, It's needed by @martinpovolny.

[abonas]

so is it waiting for review/merge?
@martinpovolny what feature is this needed for?
(feature freeze is super close)

[martinpovolny]

@abonas : this is needed for the GTLs to work correctly. This needs to go to the release. There's a set of > 10 PRs and this one is one of those. Once travis is green, this is merged.

[miq-bot]

Checked commits tumido/manageiq-ui-classic@f6f2dc4~...5277449 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 1 offense detected

app/controllers/miq_task_controller.rb

• ❗ - Line 360, Col 93 - Rails/TimeZone - Do not use Time.now without zone. Use one of Time.zone.now, Time.current, Time.now.in_time_zone, Time.now.utc, Time.now.getlocal, Time.now.iso8601, Time.now.jisx0301, Time.now.rfc3339, Time.now.to_i, Time.now.to_f instead.

[martinpovolny]

Ignoring failed chargeback test.