Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status and state scopes, fix time for MiqTask list #2585

Merged
merged 1 commit into from Nov 2, 2017

Conversation

tumido
Copy link
Member

@tumido tumido commented Oct 31, 2017

Fix a regression brought by: #2521
Depends on: ManageIQ/manageiq#16365

Adding :state and :status based filtering for tasks view and fix the :updated_on scope, since after a switch to reportdata it stopped working properly (Ruby date range can't be passed as string).

@tumido
Copy link
Member Author

tumido commented Oct 31, 2017

cc @martinpovolny

@tumido tumido force-pushed the miq_task_status_as_scope branch 3 times, most recently from b3ed7fd to 35bf922 Compare October 31, 2017 18:32
@miq-bot
Copy link
Member

miq-bot commented Oct 31, 2017

Checked commit tumido@3a6cc45 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@martinpovolny martinpovolny merged commit 3a8b739 into ManageIQ:master Nov 2, 2017
@martinpovolny martinpovolny added this to the Sprint 73 Ending Nov 13, 2017 milestone Nov 2, 2017
simaishi pushed a commit that referenced this pull request Nov 3, 2017
Add status and state scopes, fix time for MiqTask list
(cherry picked from commit 3a8b739)

https://bugzilla.redhat.com/show_bug.cgi?id=1509429
@simaishi
Copy link
Contributor

simaishi commented Nov 3, 2017

Gaprindashvili backport details:

$ git log -1
commit 9dd92cdbcaba681955a03f338146c2d0f0b35830
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Thu Nov 2 11:58:13 2017 +0100

    Merge pull request #2585 from tumido/miq_task_status_as_scope
    
    Add status and state scopes, fix time for MiqTask list
    (cherry picked from commit 3a8b739e4b36771f4fd8dd4f8378ba33f2c6a138)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1509429

@tumido tumido deleted the miq_task_status_as_scope branch June 26, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants