-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds support to using webpack-dev-server #2545
Conversation
config/webpack/development.js
Outdated
secure: false | ||
}, | ||
'/ws': { | ||
target: `ws://${settings.dev_server.host}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing port here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@himdel do we allow to customize the port for ws (vs wss)? is it set somewhere ?
d364391
to
fa72f04
Compare
@himdel updated. |
this allow the developer to: - use websockets in development env without apache - enjoy live reload in the browser when webpack code change to use, execute: NODE_ENV=development ./node_modules/.bin/webpack-dev-server --config config/webpack/development.js you may use PORT or WS_PORT to override the default 3000 PORT.
fa72f04
to
5b4e241
Compare
Checked commit ohadlevy@5b4e241 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
all 🍏 :-) |
This would be really great to get in soon! Current dev work with webpacks is quite slow. |
@himdel anything I can do to move this along? thanks! |
this would be exxxxcellent... 🏆 |
}, | ||
proxy: { | ||
'/': { | ||
target: `http://${settings.dev_server.host}:${env.PORT || '3000'}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a better ENV var name? (so that we can use with webpacker or foreman Procfile)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see what I can find..
anyone else who can merge this ? thanks :) |
thanks! |
this allow the developer to:
to use, execute:
NODE_ENV=development ./node_modules/.bin/webpack-dev-server --config config/webpack/development.js