Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all clusters in Compute Rate Assignment page #2692

Conversation

hstastna
Copy link

fixing https://bugzilla.redhat.com/show_bug.cgi?id=1456825

Fix displaying clusters in Compute Rate Assignment page when selecting
'Selected Cluster/Deployment Roles' in Assign to drop down menu even
when clusters have the same name (and belong to different providers) so
the name of their providers was added to their original names as prefix.

Before:
cluster1

After:
cluster2

@hstastna
Copy link
Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Nov 10, 2017
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1456825

Fix displaying clusters in Compute Rate Assignment page when
selecting 'Selected Cluster/Deployment Roles' in Assign to drop
down menu even when clusters have the same name (and belong to
different providers) so the name of their providers was added
to their original names as prefix.
@hstastna hstastna force-pushed the Chargeback_rate_assignment_duplicate_clusters branch from eac8915 to 9716715 Compare November 10, 2017 12:52
@miq-bot
Copy link
Member

miq-bot commented Nov 10, 2017

Checked commit hstastna@9716715 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Nov 23, 2017
@mzazrivec mzazrivec added this to the Sprint 74 Ending Nov 27, 2017 milestone Nov 23, 2017
@mzazrivec mzazrivec merged commit 1785f34 into ManageIQ:master Nov 23, 2017
simaishi pushed a commit that referenced this pull request Nov 27, 2017
…licate_clusters

Display all clusters in Compute Rate Assignment page
(cherry picked from commit 1785f34)

https://bugzilla.redhat.com/show_bug.cgi?id=1517918
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 4317ce12e10209559dc8d8dc7211a492ab97b867
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Nov 23 14:19:31 2017 +0100

    Merge pull request #2692 from hstastna/Chargeback_rate_assignment_duplicate_clusters
    
    Display all clusters in Compute Rate Assignment page
    (cherry picked from commit 1785f34df89e540e55923d25e3a72ac789afa343)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1517918

simaishi pushed a commit that referenced this pull request Nov 28, 2017
…licate_clusters

Display all clusters in Compute Rate Assignment page
(cherry picked from commit 1785f34)

https://bugzilla.redhat.com/show_bug.cgi?id=1518392
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 9f7ea75bb2c214ed69db33bbab768ca29a1c6ab3
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Thu Nov 23 14:19:31 2017 +0100

    Merge pull request #2692 from hstastna/Chargeback_rate_assignment_duplicate_clusters
    
    Display all clusters in Compute Rate Assignment page
    (cherry picked from commit 1785f34df89e540e55923d25e3a72ac789afa343)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants