Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ad hoc metrics for OPS] Remove tooltips and add spinners #27

Merged
merged 1 commit into from Jan 3, 2017

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Dec 25, 2016

Description
Refactor ManageIQ/manageiq#12165

  • Add spinners when data is loading
  • Add titles for tables in the expanded list veiw
  • Remove tooltips that are just verbatim copy of the labels.

Screenshots
Spinners
screenshot-2016-12-07-11-14-20

Titles
screenshot-2016-12-07-11-14-45

(converted from ManageIQ/manageiq#13033)

(cherry picked from commit 8a1795f82b63e91981057696f936c1b9627343f5)
@miq-bot
Copy link
Member

miq-bot commented Dec 25, 2016

Checked commit yaacov@fe43bcc with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. 🍪

@yaacov
Copy link
Member Author

yaacov commented Dec 28, 2016

This is converted from ManageIQ/manageiq#13033 :

@serenamarie125 @simon3z @himdel @moolitayer @zeari please review / merge

@martinpovolny martinpovolny merged commit 32307e6 into ManageIQ:master Jan 3, 2017
@martinpovolny martinpovolny added this to the Sprint 52 Ending Jan 23, 2017 milestone Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants