Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ad hoc metrics for OPS] Remove tooltips and add spinners #13033

Closed
wants to merge 1 commit into from

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Dec 7, 2016

Description
Refactor #12165

  • Add spinners when data is loading
  • Add titles for tables in the expanded list veiw
  • Remove tooltips that are just verbatim copy of the labels.

Screenshots
Spinners
screenshot-2016-12-07-11-14-20

Titles
screenshot-2016-12-07-11-14-45

@yaacov
Copy link
Member Author

yaacov commented Dec 7, 2016

@miq-bot add_label providers/containers,ui,refactor

@simon3z @zeari @moolitayer please review

@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2016

@yaacov Cannot apply the following label because they are not recognized: refactor

@miq-bot
Copy link
Member

miq-bot commented Dec 7, 2016

Checked commit yaacov@8a1795f with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🏆

@simon3z
Copy link
Contributor

simon3z commented Dec 7, 2016

👍 if this was agreed with @serenamarie125
Maybe @himdel can review this for the haml/css side.

@yaacov
Copy link
Member Author

yaacov commented Dec 7, 2016

@simon3z
I think @serenamarie125 is OK with #13038
We still need @serenamarie125 review on this one.

@serenamarie125
Copy link

@yaacov @simon3z I am 👍

@miq-bot
Copy link
Member

miq-bot commented Dec 22, 2016

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

@yaacov
Copy link
Member Author

yaacov commented Dec 25, 2016

moved to ManageIQ/manageiq-ui-classic#27

@yaacov yaacov closed this Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants