Order Sub Metrics of Storage types in Rate editor #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label chargeback, gaprindashvili/yes |
|
@hstastna Cannot apply the following label because they are not recognized: chargeback |
hstastna
force-pushed
the
Sub_metrics_storage_Chargeback_rate_edit
branch
2 times, most recently
from
f0cfd69
to
2b8ae25
Compare
fixing ManageIQ#2799 Order Sub Metrics of Storage types in Rate editor correctly when editing newly created Chargeback Rate in Cloud Intel -> Chargeback -> Rates.
hstastna
force-pushed
the
Sub_metrics_storage_Chargeback_rate_edit
branch
from
2b8ae25
to
b1c6bc7
Compare
|
Checked commit hstastna@b1c6bc7 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 app/views/chargeback/_cb_rate_edit_table.html.haml
|
|
@miq-bot add_label bug |
|
�@miq-bot assign @mzazrivec |
|
@hstastna Cannot apply the following label because they are not recognized: chargeback |
|
@miq-bot assign @mzazrivec |
lpichler
approved these changes
Dec 12, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 14, 2017
…_rate_edit Order Sub Metrics of Storage types in Rate editor (cherry picked from commit 42bc7e3) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1526068
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing
Issue with more info: #2799
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1517802
Order Sub Metrics of Storage types (under Rate Details) in Rate editor
correctly when editing newly created Chargeback Rate in Cloud Intel ->
Chargeback -> Rates.
Details:
The problem was that Rate Details were not sorted when editing the details after choosing
Edit this Chargeback Rate under Configuration comparing to showing the details where the
details are sorted by group, description and sub metric.
Solution:
Adding just sorting the details by group, description and sub metric was not enough. It solved
ordering but then there the problem occurred that after editing the rate and saving the changes,
the changes did not correspond to the right row under Rate Details.
Getting the right
detail_indexsolved this. We cannot rely just on order of the details, sodetail_index is set according to the id of rate detail, so we can now get proper array from
@edit[:new][:tiers]and edit appropriate values correctly.Before:
Video:
https://user-images.githubusercontent.com/14937244/33130609-35639070-cf94-11e7-9826-86bb8a18cb61.gif
Example:
After:
