Fix bug where calling getItem without name text would cause error

[karelhala]

Fixes error when calling report data API with id would throw error on items without name

When performing call sendDataWithRx({"action": "get_item", "controller": "reportDataController", "data": ["10r1107"]}) on items without name it would throw error. This PR fixes such issue and enables to call get_item with full ID sendDataWithRx({"action": "get_item", "controller": "reportDataController", "data": [10000000001107]})

[karelhala]

@miq-bot add_label bug, gaprindashvili/yes, gtls
@izapolsk this PR fixes issue you reported to me.
@miq-bot assign @martinpovolny

[himdel]

@karelhala We probably should not support numeric ids at all... this will work only until the number is high enough not to work. We can only supports strings.

[himdel]

..the only way this can work reliably is that both id and long_id are always a string, the value in the rx message is also a string, and the data in GTL must also be a string.

Otherwise, this wont work with ids in regions with large number.

So I suggest dropping the type check, and simply looking at both id and long_id, oring the result.

[karelhala]

@himdel sound reasonable. Dropped the typecheck and identificator is now check for long_id and id. Although I would rather keep simple comparison == without type check so we don't have to rely on type in GTLs and in Rx's params.

[himdel]

@karelhala Agreed on ==, makes sense if we're not 100% sure a number will never come in.

(In the mean time, I talked with QE and seems like they don't use a region value that high, so it will probably work even if they do send a number.)

((That said, we may need QE to test even with larger region numbers at some point, so maybe we will still have to add a check later.))

Another thing I noticed, long_id still comes as a number from the server.. doing a PR to fix that, but not sure if that can go to gaprindashvili safely (#2902).

[himdel]

@karelhala Maybe you forgot to push? I'm still seeing that typeof identifier === "string" - https://github.com/ManageIQ/manageiq-ui-classic/pull/2898/files#diff-919045e0fab39ba4125aa7bc96d16a3eR114

[martinpovolny]

(In the mean time, I talked with QE and seems like they don't use a region value that high, so it will probably work even if they do send a number.)

We should suggest them that they actually DO use a high enough number to make things fail.

pong @mfalesni, @jkrocil

[miq-bot]

Checked commit karelhala@893cd98 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

[himdel]

Merged, LGTM now :)

We should suggest them that they actually DO use a high enough number to make things fail.

Agreed, this could be useful :).

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 16f3fc2b2ad6a7545a13497263bab3c86658fda9
Author: Martin Hradil <himdel@seznam.cz>
Date:   Tue Dec 5 19:01:59 2017 +0000

    Merge pull request #2898 from karelhala/gtlAPIImprovements
    
    Fix bug where calling getItem without name text would cause error
    (cherry picked from commit 6bae823c3bd57c44f163cf55236c4de563564504)