New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReportData - change long_id to string #2902
Conversation
needed so that it's not bigger than INT_MAX in JS, for large region numbers
( |
(Note to self: #2842 introduces 2 more tests that need a |
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/716037a305eb462f5ee6a6ae4caadd593f7ee015 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
ReportData - change long_id to string (cherry picked from commit 59164c2)
Gaprindashvili backport details:
|
issue: #1405 |
@miq-bot add_label blocker |
long_id
in report data comes from the@record.id
field - but Ruby ints can be bigger than JS ints => weneed a string so that it's not bigger than INT_MAX in JS, for large region numbers.
Cc @karelhala