Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReportData - change long_id to string #2902

Merged
merged 1 commit into from Dec 4, 2017
Merged

ReportData - change long_id to string #2902

merged 1 commit into from Dec 4, 2017

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Dec 1, 2017

long_id in report data comes from the @record.id field - but Ruby ints can be bigger than JS ints => we
need a string so that it's not bigger than INT_MAX in JS, for large region numbers.

Cc @karelhala

needed so that it's not bigger than INT_MAX in JS, for large region numbers
@himdel
Copy link
Contributor Author

himdel commented Dec 1, 2017

(gaprindashvili/yes - most likely needed by #2791)

@himdel
Copy link
Contributor Author

himdel commented Dec 1, 2017

(Note to self: #2842 introduces 2 more tests that need a to_s)

@miq-bot
Copy link
Member

miq-bot commented Dec 1, 2017

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/716037a305eb462f5ee6a6ae4caadd593f7ee015 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Dec 4, 2017
@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 4, 2017
@mzazrivec mzazrivec merged commit 59164c2 into ManageIQ:master Dec 4, 2017
@himdel himdel deleted the str-long-i branch December 4, 2017 13:26
simaishi pushed a commit that referenced this pull request Dec 4, 2017
ReportData - change long_id to string
(cherry picked from commit 59164c2)
@simaishi
Copy link
Contributor

simaishi commented Dec 4, 2017

Gaprindashvili backport details:

$ git log -1
commit d63d0f11e7544962c5f987e830327c83d5d1cc6a
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Dec 4 09:00:23 2017 +0100

    Merge pull request #2902 from himdel/str-long-i
    
    ReportData - change long_id to string
    (cherry picked from commit 59164c296d8b757aaf4c8e98fc61ff946649874c)

@himdel
Copy link
Contributor Author

himdel commented Aug 3, 2018

issue: #1405

@JPrause
Copy link
Member

JPrause commented Oct 3, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants