Remove unnecessary, dead and duplicate code around reports_menu

[skateman]

I started to untangle the code around the reports_menu and after a few 💥 💥 💥 found some stuff to clean up. For example setting @sb[:rpt_menu] and @sb[:grp_title] twice:

def reports_menu_in_sb		
  @sb[:rpt_menu]  = populate_reports_menu("reports", "menu")		
  @sb[:grp_title] = reports_group_title		
end

# ...

def populate_reports_menu(tree_type = 'reports', mode = 'menu')
  # ...
  @sb[:rpt_menu] = get_reports_menu(group, tree_type, mode)
end

# ...

def get_reports_menu
  # ...
  @sb[:grp_title] = reports_group_title
  # ...
end

After the cleanup the reports_menu_in_sb became an alias for populate_reports_menu and in its spec was misleading. So I decided to drop the method completely and rename the spec to #populate_reports_menu as it is actually testing that method.

@miq-bot add_label refactoring, cloud intel/reporting, gaprindashvili/no

[miq-bot]

Checked commit skateman@97f1814 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍪

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 021bc3a72c549dff2189dd0847fd0fe1e264d78a
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Mon Jan 8 14:56:12 2018 +0100

    Merge pull request #3187 from skateman/reports-menu-deduplicate
    
    Remove unnecessary, dead and duplicate code around reports_menu
    (cherry picked from commit ffbc07fe5a001f68a42aa439ff643a89c8283ee0)