Add both custom reports and custom report menu items to report menu

[skateman]

The code is nearly unreadable and honestly, I don't see the bigger picture here and have no idea how this get_reports_menu should behave. The fix is an ugly hack and it might break everything in cases which I don't even know if exist at all. Writing tests around something I don't understand is IMHO meaningless and it might cause even more problems.

If you go to Cloud Intel -> Reports (menu) -> Reports (accordion), you will see both the custom menus created under the Edit Report Menus (accordion) for the current user's group and the custom reports created (if any). Originally the manually edited report menus were not displayed, that has been fixed by #3098, that broke custom reports.

Because of #3187 there will be a merge conflict for gaprindashvili so I will create a separate PR for that.

@h-kataria could you please take a look at this? It might need some extra testing on each place where this is being used.

@miq-bot add_label bug, cloud intel/reports, gaprindashvili/yes
@miq-bot assign @h-kataria

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1531600

[miq-bot]

@skateman Cannot apply the following label because they are not recognized: cloud intel/reports

[miq-bot]

Checked commit skateman@d18c53b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍪

[h-kataria]

verified fix in UI, Custom reports folder is visible when logged in as admin. Created a new user for example "test" user, then edited reports menu for the "test" user's group, after assigning user's group some custom reports i was able to see them in Reports accordion after i logged in as
"test" user.

[simaishi]

Backported to Gaprindashvili via #3224