Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failing middleware tests #3260

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Jan 17, 2018

This is to get rid of the following CI failures:

Failures:
  1) MiddlewareServerController Standalone server operations: stop button operation should create timeline event
     Failure/Error: expect(event.ems_id).to eq(ems.id)
     
     NoMethodError:
       undefined method `ems_id' for nil:NilClass
     # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
     # ./spec/controllers/middleware_server_controller_spec.rb:198:in `block (4 levels) in <top (required)>'
  2) MiddlewareServerController Standalone server operations: shutdown button operation should create timeline event
     Failure/Error: expect(event.ems_id).to eq(ems.id)
     
     NoMethodError:
       undefined method `ems_id' for nil:NilClass
     # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
     # ./spec/controllers/middleware_server_controller_spec.rb:198:in `block (4 levels) in <top (required)>'
  3) MiddlewareServerController Standalone server operations: resume dialog operation should create timeline event
     Failure/Error: expect(event.ems_id).to eq(ems.id)
     
     NoMethodError:
       undefined method `ems_id' for nil:NilClass
     # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
     # ./spec/controllers/middleware_server_controller_spec.rb:211:in `block (4 levels) in <top (required)>'
  4) MiddlewareServerController Standalone server operations: stop dialog operation should create timeline event
     Failure/Error: expect(event.ems_id).to eq(ems.id)
     
     NoMethodError:
       undefined method `ems_id' for nil:NilClass
     # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
     # ./spec/controllers/middleware_server_controller_spec.rb:211:in `block (4 levels) in <top (required)>'
  5) MiddlewareServerController Standalone server operations: reload dialog operation should create timeline event
     Failure/Error: expect(event.ems_id).to eq(ems.id)
     
     NoMethodError:
       undefined method `ems_id' for nil:NilClass
     # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
     # ./spec/controllers/middleware_server_controller_spec.rb:211:in `block (4 levels) in <top (required)>'
  6) MiddlewareServerController Standalone server operations: suspend dialog operation should create timeline event
     Failure/Error: expect(event.ems_id).to eq(ems.id)
     
     NoMethodError:
       undefined method `ems_id' for nil:NilClass
     # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
     # ./spec/controllers/middleware_server_controller_spec.rb:211:in `block (4 levels) in <top (required)>'
  7) MiddlewareServerController Standalone server operations: suspend button operation should create timeline event
     Failure/Error: expect(event.ems_id).to eq(ems.id)
     
     NoMethodError:
       undefined method `ems_id' for nil:NilClass
     # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
     # ./spec/controllers/middleware_server_controller_spec.rb:198:in `block (4 levels) in <top (required)>'
  8) MiddlewareServerController Standalone server operations: resume button operation should create timeline event
     Failure/Error: expect(event.ems_id).to eq(ems.id)
     
     NoMethodError:
       undefined method `ems_id' for nil:NilClass
     # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
     # ./spec/controllers/middleware_server_controller_spec.rb:198:in `block (4 levels) in <top (required)>'
  9) MiddlewareServerController Standalone server operations: restart button operation should create timeline event
     Failure/Error: expect(event.ems_id).to eq(ems.id)
     
     NoMethodError:
       undefined method `ems_id' for nil:NilClass
     # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
     # ./spec/controllers/middleware_server_controller_spec.rb:198:in `block (4 levels) in <top (required)>'
  10) MiddlewareServerController Standalone server operations: reload button operation should create timeline event
      Failure/Error: expect(event.ems_id).to eq(ems.id)
      
      NoMethodError:
        undefined method `ems_id' for nil:NilClass
      # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
      # ./spec/controllers/middleware_server_controller_spec.rb:198:in `block (4 levels) in <top (required)>'
  11) MiddlewareServerController Standalone server operations: restart dialog operation should create timeline event
      Failure/Error: expect(event.ems_id).to eq(ems.id)
      
      NoMethodError:
        undefined method `ems_id' for nil:NilClass
      # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
      # ./spec/controllers/middleware_server_controller_spec.rb:211:in `block (4 levels) in <top (required)>'
  12) MiddlewareServerController Standalone server operations: shutdown dialog operation should create timeline event
      Failure/Error: expect(event.ems_id).to eq(ems.id)
      
      NoMethodError:
        undefined method `ems_id' for nil:NilClass
      # ./spec/controllers/middleware_server_controller_spec.rb:164:in `timeline_event_expectations'
      # ./spec/controllers/middleware_server_controller_spec.rb:211:in `block (4 levels) in <top (required)>'
  13) MiddlewareDomainController domain operations: stop operation should create timeline event
      Failure/Error: expect(event.ems_id).to eq(ems.id)
      
      NoMethodError:
        undefined method `ems_id' for nil:NilClass
      # ./spec/controllers/middleware_domain_controller_spec.rb:69:in `block (3 levels) in <top (required)>'

@mzazrivec mzazrivec added the test label Jan 17, 2018
@miq-bot
Copy link
Member

miq-bot commented Jan 17, 2018

Checked commit mzazrivec@36e7b47 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@himdel
Copy link
Contributor

himdel commented Jan 17, 2018

Caused by ManageIQ/manageiq#16729, adding gaprindashvili/yes.

@himdel himdel closed this Jan 17, 2018
@himdel himdel reopened this Jan 17, 2018
@himdel himdel merged commit 43ed1d6 into ManageIQ:master Jan 17, 2018
@himdel himdel added this to the Sprint 78 Ending Jan 29, 2018 milestone Jan 17, 2018
simaishi pushed a commit that referenced this pull request Jan 17, 2018
…ts_2

Remove failing middleware tests
(cherry picked from commit 43ed1d6)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 3ede7b5009998b4471e1bc3b26815b7e8870b759
Author: Martin Hradil <himdel@seznam.cz>
Date:   Wed Jan 17 14:17:19 2018 +0100

    Merge pull request #3260 from mzazrivec/remove_failing_middleware_tests_2
    
    Remove failing middleware tests
    (cherry picked from commit 43ed1d6398bf3d9b6e5c3239c0f9817755663eef)

@mzazrivec mzazrivec deleted the remove_failing_middleware_tests_2 branch February 22, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants