DialogEditor - remove code that changes fields to refresh from name to id #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o id since ManageIQ/ui-components#228 , we're using `name` instead of `id` in `fields_to_refresh`. Previously, we used the `id` and this bit of code converted the names coming from the API to ids. That's counter-productive now, removing :) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536528
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/abc36173921c07e4d02a6615020ecc3b54839a6c with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
romanblanco
approved these changes
Jan 23, 2018
simaishi
pushed a commit
that referenced
this pull request
Jan 23, 2018
DialogEditor - remove code that changes fields to refresh from name to id (cherry picked from commit 0db59ee) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1537571
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ManageIQ/ui-components#228 , we're using
nameinstead ofidinfields_to_refresh.Previously, we used the
idand this bit of code converted the names coming from the API to ids.That's counter-productive now, removing :)
(This is a two-part fix, ManageIQ/ui-components#238 should go first.)
Testing: go to
/miq_ae_customization/editor, create a dynamic field and a non-dynamic field.Edit the non-dynamic field's "Fields to Refresh" to use the dynamic field.
Save the dialog, edit it.
See the non-dynamic field's "Fields to Refresh".
before: empty, now: the value set when creating
Cc: @romanblanco @eclarizio
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1536528