Use '.name' instead of '.id' for refresh field list #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All those EDIT: fixed 👍 |
|
Nice DRYing up 👍 -ng-options="dynamicField.id as dynamicField.label for dynamicField in vm.modalData.dynamicFieldList"
+ng-options="dynamicField.name as dynamicField.label for dynamicField in vm.modalData.dynamicFieldList" |
|
Checked commit eclarizio@15d190e with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 |
romanblanco
suggested changes
Jan 8, 2018
There was a problem hiding this comment.
@eclarizio The fix does not work for me. I'm getting error messages in console after trying to edit an existing dialog:
TypeError
columnNumber: 13
fileName: "http://localhost:3000/assets/manageiq-ui-components/dist/js/ui-components.self-b957ce520f3f74eea649dcfe3bfa869caca663ad12dd05297d9a5edc6f9d7234.js?body=1"
lineNumber: 2094
message: "field.values is undefined"
EDIT: my mistake, works good
romanblanco
approved these changes
Jan 8, 2018
|
@miq-bot add_label gaprindashvili/backported This was released in manageiq-ui-components 1.0.5, backported to gaprindashvili via ManageIQ/manageiq-ui-classic#3203 . |
This was referenced Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that when creating or editing dialogs, if you add a new field, the field is not saved before the associations are created, and so there is no id to send up. Therefore we have to send up the name and have the backend handle the association creation by name instead.
This will need to be combined with this main repo PR in order to fully fix the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1518942
@miq-bot add_label gaprindashvili/yes, bug
@romanblanco @himdel Please review