Menu pluggability improvements #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpovolny
force-pushed
the
menu_plug
branch
from
b9fb7b9
to
f927b49
Compare
martinpovolny
force-pushed
the
menu_plug
branch
from
f927b49
to
07368c5
Compare
Allow plugins to add items and sections at a given position in a
existing section.
Examples:
initializer 'plugin' do
# create custom section with 2 custom items
Menu::CustomLoader.register(
Menu::Section.new(:spike, N_('Plugin'), 'fa fa-map-pin', [
Menu::Item.new('plug1', N_('Test'), 'miq_report', {:feature => 'miq_report', :any => true}, '/plug'),
Menu::Item.new('plug2', N_('Demo'), 'miq_report', {:feature => 'miq_report', :any => true}, '/demo')
])
)
# create custom item placed in an existing section 'vi' (Cloud Intel)
Menu::CustomLoader.register(
Menu::Item.new('plug3', N_('Plug Item'), 'miq_report', {:feature => 'miq_report', :any => true}, '/demo', :default, :vi)
)
# create custom section and place it before existing section 'compute' (Compute)
Menu::CustomLoader.register(
Menu::Section.new(:spike3, N_('Plugin 2'), 'fa fa-map-pin', [
Menu::Item.new('plug4', N_('Demo'), 'miq_report', {:feature => 'miq_report', :any => true}, '/demo')
], :default, :compute)
)
# create custom section and place it inside an existing section 'compute' (Compute), before existing subsection 'clo' (Cloud)
Menu::CustomLoader.register(
# Struct.new(:id, :name, :icon, :items, :placement, :before, :type, :href, :parent_id
Menu::Section.new(:spike3, N_('Nested section after'), 'fa fa-map-pin', [
Menu::Item.new('plug5', N_('Test item'), 'miq_report', {:feature => 'miq_report', :any => true}, '/demo')
], :default, :clo, :default, nil, :compute)
)
end
martinpovolny
changed the title
|
@ZitaNemeckova, @himdel : added the specs. Should be good to merge. I can change the interface to work with hashes (to have named arguments) but it can by also done in a separate PR. |
|
LGTM 👍 (except for the failing spec :P) |
martinpovolny
force-pushed
the
menu_plug
branch
2 times, most recently
from
ac190d5
to
a727485
Compare
|
Checked commits martinpovolny/manageiq-ui-classic@928f093~...01fffca with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 spec/presenters/menu/custom_loader_spec.rb
|
|
Tested with https://github.com/priley86/miq_v2v_ui_plugin/pull/48, works just fine 👍 |
|
#3963: Together with #3683, fixes menu for v2v in gaprindashvili. Then #3726 is needed to fix a bug here. |
This was referenced May 20, 2018
Closed
simaishi
pushed a commit
that referenced
this pull request
May 31, 2018
Menu pluggability improvements (cherry picked from commit 19b59d9)
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand menu pluggability:
Details and examples can be seen in the commit message.
TODO: