Menu::Manager - support adding to existing sections

[himdel]

Right now, plugins can add new sections and items in the menu, but can't append to existing sections.

Menu sections already have ids, with this PR, if you create an already existing section in a plugin, it will get merged with the existing one.

Cc @ZitaNemeckova, @priley86
@martinpovolny please review

This is so that v2v can replace priley86@5367072 with an in-plugin solution.

[himdel]

Testing:

diff --git a/lib/manageiq/ui/classic/engine.rb b/lib/manageiq/ui/classic/engine.rb
index 60431e639..aadf4b4c4 100644
--- a/lib/manageiq/ui/classic/engine.rb
+++ b/lib/manageiq/ui/classic/engine.rb
@@ -57,6 +57,17 @@ module ManageIQ
         def vmdb_plugin?
           true
         end
+
+        initializer 'plugin' do
+          Menu::CustomLoader.register(
+            Menu::Section.new(:compute, N_("Compute"), 'pficon pficon-cpu', [
+              Menu::Section.new(:migration, N_("Migration"), 'fa fa-plus', [
+                Menu::Item.new('overview', N_('Overview'), 'miq_report', {:feature => 'miq_report', :any => true}, '/migration')
+              ])
+            ])
+          )
+        end
+
       end
     end
   end

Make sure Migration appears under (=inside) Compute.

[miq-bot]

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/c0e5b78055eddc106cc0267764f2eccc18439a43 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

[ZitaNemeckova]

Tested with https://github.com/priley86/miq_v2v_ui_plugin/pull/48. Works in UI. LGTM 👍

[martinpovolny]

well I have this ready here: #3347 and I actually said so on the standups a couple of times ;-)

I just kept it marked as "WIP" because I have no test coverage. But there's no tests here either ;-)

[himdel]

Well, standups are audio-only :)

So.. yours is longer so probably does more :). Should I close this one then? (as in, can we merge the other one soon? :))

And how would it work, something llike..

Menu::CustomLoader.register(
  Menu::Section.new(:migration, N_("Migration"), 'fa fa-plus', [
    Menu::Item.new('overview', N_('Overview'), 'miq_report', {:feature => 'miq_report', :any => true}, '/migration')
  ], nil, nil, nil, nil, :compute)
)

?

EDIT: answered in the commit description (07368c5), short answer: yes.

[himdel]

Closed in favor of #3347

[priley86]

thanks very much @ZitaNemeckova @martinpovolny @himdel ... nice work! 👍

happy to adopt this!