Fix for different behavior of items in regards to default values on dialog sample page #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit eclarizio@d7b7344 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
looks good. |
simaishi
pushed a commit
that referenced
this pull request
Feb 6, 2018
Fix for different behavior of items in regards to default values on dialog sample page (cherry picked from commit 4bddbcf) https://bugzilla.redhat.com/show_bug.cgi?id=1542610
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change to the sample page of a dialog (when you click on it in the accordion list and it shows some basic sample of what it's going to look like in the right cell). We're merely taking into account default values that were not being utilized before. The radio button sample was also just completely incorrect and needed to be modified.
This fixes part of https://bugzilla.redhat.com/show_bug.cgi?id=1540273, the fix for the timepicker not showing up in the service-ui will likely be needed in the ui-components repo.
@miq-bot add_label gaprindashvili/yes, bug, blocker
@miq-bot assign @dclarizio