Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for different behavior of items in regards to default values #248

Merged
merged 2 commits into from Feb 6, 2018

Conversation

eclarizio
Copy link
Member

Related to ManageIQ/manageiq-ui-classic#3371

This should fix the issue with the timepicker not being visible in the service UI, and also fixes another issue I found with the checkbox not displaying the correct default value on the initial load of ordering the service.

https://bugzilla.redhat.com/show_bug.cgi?id=1540273

@miq-bot add_label gaprindashvili/yes, bug, blocker
@miq-bot assign @himdel

@miq-bot
Copy link
Member

miq-bot commented Feb 5, 2018

Checked commits eclarizio/ui-components@1154f59~...0694c63 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, fixes the issues, looks OK 👍

@himdel himdel merged commit 0225b6e into ManageIQ:master Feb 6, 2018
@himdel himdel added this to the Sprint 79 Ending Feb 12, 2018 milestone Feb 6, 2018
@himdel
Copy link
Contributor

himdel commented Feb 6, 2018

Backported to gaprindashvili branch:

commit 0052af3b4bc3d5b5a55456efaff97cf0623943b2 (HEAD -> gaprindashvili)
Author: Martin Hradil <himdel@seznam.cz>
Date:   Tue Feb 6 16:35:27 2018 +0100

    Merge pull request #248 from eclarizio/BZ1540273
    
    Fix for different behavior of items in regards to default values
    
    (cherry picked from commit 0225b6e0067d12942890f03028cc0bbb2a0b1491)

himdel added a commit that referenced this pull request Feb 6, 2018
Fix for different behavior of items in regards to default values

(cherry picked from commit 0225b6e)
@himdel
Copy link
Contributor

himdel commented Feb 6, 2018

Released in manageiq-ui-components 1.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants