Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINE] Remove duplicate flash message on tag reset #3445

Merged
merged 1 commit into from
Mar 14, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Feb 21, 2018

Remove duplicate flash message on tag reset
This issue exists only on the Fine branch, it was already fixed upstream.

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1533082

Before:

screenshot from 2018-02-21 10-10-36

After:
screenshot from 2018-02-21 10-00-15

@lgalis
Copy link
Contributor Author

lgalis commented Feb 21, 2018

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Feb 21, 2018
@miq-bot
Copy link
Member

miq-bot commented Feb 21, 2018

Checked commit lgalis@b28cdfc with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@lgalis
Copy link
Contributor Author

lgalis commented Mar 14, 2018

@dclarizio - would you or @simaishi be able to merge this 'FINE' only PR?

@simaishi simaishi assigned simaishi and unassigned dclarizio Mar 14, 2018
@simaishi
Copy link
Contributor

I didn't see this PR as it wasn't assigned to me...

@simaishi simaishi merged commit fe9e9b9 into ManageIQ:fine Mar 14, 2018
@simaishi simaishi added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 14, 2018
@lgalis lgalis deleted the fine_duplicate_flash_on_tag_reset branch March 15, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants