Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional presets for v2v #3527

Merged
merged 1 commit into from Mar 8, 2018
Merged

Conversation

priley86
Copy link
Member

@priley86 priley86 commented Mar 7, 2018

Thank you for a new Pull Request!

Please, make reviewers work easier by checking, if you are not introducing any technical debt:
https://github.com/ManageIQ/guides/blob/master/reviewers_guidelines.md#manageiqmanageiq-ui-classic

Describe the rationale and use case for this pull request. Provide any background, examples, and images that provide further information to accurately describe what it is that you are adding to the repo. Add subsections as necessary to organize and feel free to link and reference other PRs as necessary, but also include them in the links section below as a quick reference.

Guidelines:

  • Keep Pull Request titles short and to the point, ideally under 72 characters
  • Provide as much context/info in the description as necessary to get the reviewer up to the same domain knowledge level as yourself
  • Keep code changes as short as possible and implementing a single feature/fix/refactoring, when possible

Links [Optional]

Steps for Testing/QA [Optional]

If there are any manual steps that you would like the reviewer(s) to take to verify your changes, please describe in detail the steps to reproduce the features added by the pull request, or the bug before and after the change.

@miq-bot
Copy link
Member

miq-bot commented Mar 7, 2018

Checked commit priley86@44a5ecb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@himdel
Copy link
Contributor

himdel commented Mar 8, 2018

@priley86 I'm good with this change, but please update the PR description ;)

@martinpovolny martinpovolny added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 8, 2018
@martinpovolny martinpovolny merged commit e68d90b into ManageIQ:master Mar 8, 2018
@martinpovolny martinpovolny self-assigned this Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants