[GAPRINDASHVILI] Backport Webpack related changes #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Fixes ERROR in miq_v2v_ui/migration-fb9c22b04d26650200ab.js from UglifyJs Unexpected token operator «=», expected punc «,» [/home/himdel/miq_v2v_ui_plugin/node_modules/csv-generate/lib/index.js:69,0][miq_v2v_ui/migration-fb9c22b04d26650200ab.js:155704,30] when running NODE_ENV=production bin/webpack
not really being used in gaprindashvili, makes the build wiring a bit less complicated
this is a backport of #3828, without the (development) WEBPACK_EXCLUDE_NODE_MODULES support
backport of #4058
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/5be1f46be8566337e8239f08a2e451d438289428~...6becf494eda74be8440eecbace517566d4e3c19c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
I think #4056 is not the one you wanted to link 😉 |
|
Indeed, #4058 it is, sorry :) |
mzazrivec
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a gaprindashvili backport of (parts of):
#2652
#3291
#3312
#3502
#3506
#3527
#3719
#3828
#4058
This should bring gaprindashvili roughly on par with master as far as webpack is concerned, except for:
#3963: this should bring the webpack config up to date, but does not touch the rake tasks - separate PR for that..