API js - use base64encode which can deal with UTF8 passwords #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can't really assume the login screen will depend only on old JS anymore
`window.btoa("sněhulák")` fails on InvalidCharacterError: String contains an invalid character
because it only expects latin1 chars
We need to base64 encode the login:password pair even when the password uses non-latin1 chars :)
Implementation adapted from https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#Solution_2_%E2%80%93_rewrite_the_DOMs_atob()_and_btoa()_using_JavaScript's_TypedArrays_and_UTF-8
https://bugzilla.redhat.com/show_bug.cgi?id=1527316
|
Testing: add a user with special (unicode) characters in the password |
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/af3c209964ca45c8cf4297b909383e2ab0e5e155~...6a0688bdc591be091cbb0cd822c9e827a9031745 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
gaprindashvili: Please backport together with #3687, which fixes a bug in older browsers |
|
@himdel Can this (and related PRs) be |
simaishi
pushed a commit
that referenced
this pull request
Apr 2, 2018
API js - use base64encode which can deal with UTF8 passwords (cherry picked from commit aa6b2fd) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1562797
|
Gaprindashvili backport details: |
|
@simaishi They can't, I think I need to create a separate PR - no webpack in fine. On it.. :) |
|
Fine version created in #3711 |
|
Backported to Fine via #3711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 2 npm packages:
base64js- JS implementation of base64 which can deal with arbitrary encodingstext-encoder-lite- a shim for the TextEncoder api, useable for utf8 strings (even in IE)and replaces the
API.loginuse ofwindow.btoawith a custombase64encodefunction implemented using the 2 libraries.This way, users can use passwords with unicode chars.
Note: on modern browsers, this will handle any unicode password, including emoji.
On IE, more modern unicode versions may not be fully supported (czech or japanese chars should be fine, emoji may not).
The difference:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1527316