[FINE] API - use a utf-8 aware btoa implementation (base64encode) #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`window.btoa("sněhulák")` fails on InvalidCharacterError: String contains an invalid character
because it only expects latin1 chars
We need to base64 encode the login:password pair even when the password uses non-latin1 chars :)
Implementation adapted from https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#Solution_2_%E2%80%93_rewrite_the_DOMs_atob()_and_btoa()_using_JavaScript's_TypedArrays_and_UTF-8
(This corresponds to master PRs:
* #3682 (updated to work in ES5, and dependencies via bower)
* #3687 (not really needed because we're using the globals here)
* #3709 (gaprindashvili fix removing a vendor mention, not really needed here)
)
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1562798
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/173cc7d63ba2fe70574631f34f24c11d9ae3b6e4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
martinpovolny
approved these changes
Apr 9, 2018
This was referenced Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fine version of:
window.btoa("sněhulák")fails on InvalidCharacterError: String contains an invalid characterbecause it only expects latin1 chars
We need to base64 encode the login:password pair even when the password uses non-latin1 chars :)
Implementation adapted from https://developer.mozilla.org/en-US/docs/Web/API/WindowBase64/Base64_encoding_and_decoding#Solution_2_%E2%80%93_rewrite_the_DOMs_atob()_and_btoa()_using_JavaScript's_TypedArrays_and_UTF-8
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1562798