Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json - remove Angular 2+ dependencies #3719

Merged
merged 1 commit into from Apr 5, 2018
Merged

package.json - remove Angular 2+ dependencies #3719

merged 1 commit into from Apr 5, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Apr 4, 2018

None of these are used, not by ui-classic, nor v2v or graphql.

If we ever get a angular-based plugin, that plugin can depend on angular by itself.

Closes #3715

none of these are used, nor by ui-classic, nor v2v or graphql

if we ever get a angular-based plugin, that plugin can depend on angular by itself
@miq-bot
Copy link
Member

miq-bot commented Apr 4, 2018

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/6404265086f0b60c5203679d63d570bbf0729fbc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec self-assigned this Apr 5, 2018
@mzazrivec mzazrivec added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 5, 2018
@mzazrivec mzazrivec merged commit 19be4e3 into ManageIQ:master Apr 5, 2018
@himdel himdel deleted the remove-ng branch April 5, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants