Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of trees for new group #379

Merged
merged 1 commit into from Feb 16, 2017

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Feb 14, 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1421196

Configuration -> Access Control -> Groups -> Configuration -> Add new group -> try tabs Red Hat Tags, Hosts/Nodes & Clusters/Deployment Roles, VMs &Templates

One tree maybe rendered but others won't.

Before:
screen shot 2017-02-14 at 11 40 27 am

After:
screen shot 2017-02-14 at 11 36 29 am

Darga version: ManageIQ/manageiq#14321

@miq-bot add_label bug

@ZitaNemeckova
Copy link
Contributor Author

Introduced by #68 so...
@miq-bot add_label euwe/yes, darga/yes

Ping @himdel

@miq-bot
Copy link
Member

miq-bot commented Feb 16, 2017

Checked commit ZitaNemeckova@e690110 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. 🍪

@mzazrivec mzazrivec added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 16, 2017
@mzazrivec mzazrivec merged commit 11d090f into ManageIQ:master Feb 16, 2017
@simaishi
Copy link
Contributor

simaishi commented Mar 7, 2017

@ZitaNemeckova app/presenters/tree_builder_belongs_to_hac.rb doesn't exist in Euwe branch. Please create an Euwe-specific PR (referencing this one) or suggest other PRs to backport.

@simaishi
Copy link
Contributor

simaishi commented Mar 9, 2017

Backported to Euwe via ManageIQ/manageiq#14227

@simaishi
Copy link
Contributor

Backported to Darga via ManageIQ/manageiq#14321

@ZitaNemeckova ZitaNemeckova deleted the add_missing_group_trees branch September 12, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants