Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DARGA] Fix creating trees for new group #14321

Merged

Conversation

ZitaNemeckova
Copy link
Contributor

https://bugzilla.redhat.com/show_bug.cgi?id=1427322

Configuration -> Access Control -> Groups -> Configuration -> Add new group -> try tabs Red Hat Tags, Hosts/Nodes & Clusters/Deployment Roles, VMs &Templates

One tree maybe rendered but others won't.

Before:
screen shot 2017-02-14 at 11 40 27 am

After:
screen shot 2017-02-14 at 11 36 29 am

Darga version of ManageIQ/manageiq-ui-classic#379.

@miq-bot assign @mzazrivec

@miq-bot add_label bug, ui, darga/yes

@miq-bot miq-bot changed the title Fix creating trees for new group [DARGA] Fix creating trees for new group Mar 14, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 14, 2017

Checked commit ZitaNemeckova@90a1714 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 2 offenses detected

app/controllers/ops_controller/ops_rbac.rb

@ZitaNemeckova ZitaNemeckova changed the title [DARGA] Fix creating trees for new group [Darga] Fix creating trees for new group Mar 14, 2017
@ZitaNemeckova ZitaNemeckova reopened this Mar 14, 2017
@himdel
Copy link
Contributor

himdel commented Mar 14, 2017

@ZitaNemeckova it's supposed to be [DARGA] not [Darga], miq-bot was right ;)

@himdel
Copy link
Contributor

himdel commented Mar 14, 2017

@miq-bot assign simaishi

Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miq-bot miq-bot assigned simaishi and unassigned mzazrivec Mar 14, 2017
@Fryguy Fryguy changed the title [Darga] Fix creating trees for new group [DARGA] Fix creating trees for new group Mar 14, 2017
@himdel
Copy link
Contributor

himdel commented Mar 14, 2017

Test failures are unrelated, caused by bad conflict resolution .. creating an equivalent of #14200 for darga to fix... (=> #14325)

@himdel
Copy link
Contributor

himdel commented Mar 14, 2017

@miq-bot remove_label darga/yes

@miq-bot miq-bot removed the darga/yes label Mar 14, 2017
@simaishi simaishi merged commit eb7216a into ManageIQ:darga Mar 31, 2017
@simaishi simaishi added this to the Sprint 58 Ending Apr 10, 2017 milestone Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants