Remove Redux environment warning in production #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of blindly copying the whole environment
because the dist file has a hardcoded warning printed out when the file is minified:
```
if ("development" !== 'production' && typeof isCrushed.name === 'string' && isCrushed.name !== 'isCrushed') {
warning('You are currently using minified code outside of NODE_ENV === \'production\'. ' + 'This means that you are running a slower development build of Redux. ' + 'You can use loose-envify (https://github.com/zertosh/loose-envify) for browserify ' + 'or DefinePlugin for webpack (http://stackoverflow.com/questions/30030031) ' + 'to ensure you have the correct code for your production build.');
```
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/7face4f7bbda7964c5867844f7084f75c2ea6407~...4caf5a311750c7f2f989d8cf1a4ceaaab766a791 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
cc @Hyperkid123 can you make sure this doesn't break ngRedux please? :) |
|
I'm OK with this change, as long as @Hyperkid123 agrees here. |
Hyperkid123
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in production, there is a warning in the console:
That warning is present in both redux and ng-redux, but appears only because we're using the pre-built version of ng-redux, which was built with the development environment.
So... moving ng-redux to webpack so that we compile our own environment-dependnent version.
Also changed how we expose the environment - previously, for some reason we would take all the environment and pass it as a list of defaults to EnvironmentPlugin.
Now, we're only explicittly sharing
NODE_ENV.Testing:
Check the browser console on the login screen.
(As far as I know, this is just a warning, no point in backporting unless somebody complains.)