Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Redux environment warning in production #4341

Merged
merged 2 commits into from Jul 25, 2018
Merged

Remove Redux environment warning in production #4341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7face4f
DefinePlugin - explicitly define only process.env.NODE_ENV
himdel Jul 24, 2018
4caf5a3
ngRedux - import via webpack, not asset pipeline
himdel Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion app/assets/javascripts/application.js
View file
Open in desktop
Expand Up @@ -15,7 +15,6 @@
//= require bower_components/angular-bootstrap/ui-bootstrap-tpls
//= require angular-sanitize
//= require angular.validators/angular.validators
//= require ng-redux/dist/ng-redux
//= require bower_components/moment/moment
//= require bower_components/moment-strftime/lib/moment-strftime
//= require bower_components/moment-timezone/moment-timezone
Expand Down
1 change: 1 addition & 0 deletions app/javascript/packs/application-common.js
View file
Open in desktop
Expand Up @@ -7,6 +7,7 @@
// layout file, like app/views/layouts/application.html.erb

import 'proxy-polyfill';
import 'ng-redux';

import { mount } from '../react/mounter';
import componentRegistry from '../react/componentRegistry';
Expand Down
4 changes: 3 additions & 1 deletion config/webpack/shared.js
View file
Open in desktop
Expand Up @@ -44,7 +44,9 @@ module.exports = {
},

plugins: [
new webpack.EnvironmentPlugin(JSON.parse(JSON.stringify(env))),
new webpack.DefinePlugin({
'process.env.NODE_ENV': JSON.stringify(env.NODE_ENV || 'development'),
}),

// Workaround for graphql/graphql-language-service#128
new webpack.ContextReplacementPlugin(
Expand Down