Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render the notification drawer footer synchronously, remove its haml #4793

Merged
merged 1 commit into from Oct 18, 2018

Conversation

skateman
Copy link
Member

The ng-include directive was slower than the max-height calculation of the drawer's collapsible panel, by moving the code from the included file directly from where it is being called the timing issue is sorted out.

Before:
screenshot from 2018-10-18 16-08-17

After:
screenshot from 2018-10-18 16-08-30

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1640161

@miq-bot add_reviewer @himdel
@miq-bot add_label bug, gaprindashvili/no, hammer/yes

@miq-bot
Copy link
Member

miq-bot commented Oct 18, 2018

Checked commit skateman@9d502ea with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@himdel himdel self-assigned this Oct 18, 2018
@himdel
Copy link
Contributor

himdel commented Oct 18, 2018

LGTM, merging when green :)

(we're actually not using ng-include anywhere outside notification drawer code :))

@himdel himdel merged commit 3a35f8f into ManageIQ:master Oct 18, 2018
@himdel himdel added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 18, 2018
simaishi pushed a commit that referenced this pull request Oct 18, 2018
Render the notification drawer footer synchronously, remove its haml

(cherry picked from commit 3a35f8f)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1640161
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 39e282bfce01d4994a19a57c8fb7d8201d3a0799
Author: Martin Hradil <himdel@seznam.cz>
Date:   Thu Oct 18 17:01:52 2018 +0200

    Merge pull request #4793 from skateman/drawer-buttons
    
    Render the notification drawer footer synchronously, remove its haml
    
    (cherry picked from commit 3a35f8f1d620e13c7f1ef7842fb2e5e8aff43b8a)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1640161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants