Remove ng-include in notifications #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ng-include is problematic, started removing it in #4793, continuing
… of ng-include large template, so not inlining, but at least we can drop the extra async request for it Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1571223
|
Cc @skateman |
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/94259d4dae5b047d5b55e57a865f9921e4a36a74~...97d83f2997d27951582d64c7da14e1bfc3ad9e6b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
skateman
reviewed
Oct 23, 2018
| 'ng-repeat' => "notification in notificationGroup.notifications | limitTo:limit.notifications:(notificationGroup.notifications.length - limit.notifications)", | ||
| 'ng-include' => "notificationBodyInclude"} | ||
| 'ng-repeat' => "notification in notificationGroup.notifications | limitTo:limit.notifications:(notificationGroup.notifications.length - limit.notifications)"} | ||
| = render :partial => 'static/notification_drawer/notification-body' |
There was a problem hiding this comment.
Any reason why this needs to be in a partial?
There was a problem hiding this comment.
No reason at all, just didn't want to make the file unreadably large.
Should I just inline it too?
There was a problem hiding this comment.
Fair enough, you don't have to!
simaishi
pushed a commit
that referenced
this pull request
Oct 24, 2018
Remove ng-include in notifications (cherry picked from commit ec520f4) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1571223
|
Hammer backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4793 we started removing templates loaded asynchronously from other templates via ng-include.
Continuing with that - removing all remaining
ng-includestatements..titleIncludewas unused, removedheadingIncludewas used for a 2 line partial, inlinedsubheadingIncludethe samenotificationBodyIncludereplaced withrender :partialso that we only have to do 1 request instead of 2(
notificationFooterIncludeinlined in #4793)The result of the 2 PRs is that we're now doing only 2 notifications-related requests on load (api, and template), instead of 6.
https://bugzilla.redhat.com/show_bug.cgi?id=1571223