Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced search - use the right spinner #4847

Merged
merged 1 commit into from Oct 30, 2018
Merged

Advanced search - use the right spinner #4847

merged 1 commit into from Oct 30, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Oct 29, 2018

some actions in the advanced search modal would previously only trigger the big sparkle, which happens under the model

this makes the commit & discard buttons use the search spinner, which happens over the modal

https://bugzilla.redhat.com/show_bug.cgi?id=1469151

@himdel
Copy link
Contributor Author

himdel commented Oct 29, 2018

Before, the buttons had a lot of extra attributes, removing:

  • "data-method" => :post - only useful for remote
  • "data-miq_sparkle_on" => true - only useful for data-click-url
  • :remote => true, - useless by itself, when using onclick

But the bugfix itself is really just changing miqAjaxButton to miqAjax in the onclick, which doesn't have the nonsensical 700ms wait, causing the right spinner to appear right away.

some actions in the advanced search modal would previously only trigger the big sparkle, which happens under the model

this makes the commit & discard buttons use the search spinner, which happens over the modal

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1469151
@miq-bot
Copy link
Member

miq-bot commented Oct 29, 2018

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/c4abfe614cafe25034f34e4e5daff3025b317e9a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec mzazrivec self-assigned this Oct 30, 2018
@mzazrivec mzazrivec added this to the Sprint 98 Ending Nov 5, 2018 milestone Oct 30, 2018
@mzazrivec mzazrivec merged commit d02de02 into ManageIQ:master Oct 30, 2018
@himdel himdel deleted the adv-search-bz1469151 branch October 30, 2018 09:41
simaishi pushed a commit that referenced this pull request Oct 30, 2018
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit c40152cd3d6e10aba82be3ce610d674059c8beea
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Oct 30 10:09:41 2018 +0100

    Merge pull request #4847 from himdel/adv-search-bz1469151
    
    Advanced search - use the right spinner
    
    (cherry picked from commit d02de028497ca358e6591822379b61cce9428bd1)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1469151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants