Fix spinner behavior when clicking redo/undo change buttons in Adv Search #6051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up hash options too.
|
@bmclaughlin Cannot apply the following label because they are not recognized: "configuration management" |
|
Checked commit bmclaughlin@5fbf824 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
LGTM, thanks :) Just wondering if the other buttons there won't be affected as well... |
simaishi
modified the milestones:
Sprint 119 Ending Sep 02, 2019,
Sprint 119 Ending Sep 2, 2019
|
@bmclaughlin |
|
@bmclaughlin ping ^ |
|
@simaishi LGTM for |
simaishi
pushed a commit
that referenced
this pull request
Nov 1, 2019
Fix spinner behavior when clicking redo/undo change buttons in Adv Search (cherry picked from commit 5e7a2ec) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767833
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spinner was appearing below the modal when clicking 'Undo previous change' or 'Redo previous change' arrow buttons on Advanced Search, while the original issue noted in the BZ was fixed by #4847.
@miq-bot add_labels bug, "configuration management"
@miq-bot add_reviewer himdel
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1740239