Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceForm spec - fix by disabling disableSubmit and making sure the validator can pass #5018

Merged
merged 2 commits into from Nov 30, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Nov 30, 2018

fixes

    ✕ should enable submit button and call submit callback (30ms)

  ● Cloud tenant form component › should enable submit button and call submit callback

    expect(jest.fn()).toHaveBeenCalledWith(expected)

    Expected mock function to have been called with:
      {"description": "bar", "name": "foo"} as argument 2, but it was called with {"description": "bar", "name": "bar"}.

Introduced in #4985.
Cc @Hyperkid123 , @martinpovolny

… validator can pass

fixes

```
    ✕ should enable submit button and call submit callback (30ms)

  ● Cloud tenant form component › should enable submit button and call submit callback

    expect(jest.fn()).toHaveBeenCalledWith(expected)

    Expected mock function to have been called with:
      {"description": "bar", "name": "foo"} as argument 2, but it was called with {"description": "bar", "name": "bar"}.
```
@himdel himdel added the test label Nov 30, 2018
@himdel
Copy link
Contributor Author

himdel commented Nov 30, 2018

This also makes it possible to submit the Service form on changes.

@himdel himdel mentioned this pull request Nov 30, 2018
@miq-bot
Copy link
Member

miq-bot commented Nov 30, 2018

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/cd79859f50658dd69c88e66ca1f9333c04d1f89b~...e125d9503a98a2169680e2d74c7640e14523778d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@himdel
Copy link
Contributor Author

himdel commented Nov 30, 2018

(Verified I can now save in both the #4985 Service form, and in #4895 Cloud Tenant form, so hopefully that disableSubmit was just a testing artifact.)

@martinpovolny martinpovolny merged commit cfcef23 into ManageIQ:master Nov 30, 2018
@martinpovolny martinpovolny self-assigned this Nov 30, 2018
@martinpovolny martinpovolny added this to the Sprint 100 Ending Dec 3, 2018 milestone Nov 30, 2018
@himdel himdel deleted the fix-travis branch November 30, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants