Replace service form #4985
Replace service form #4985
Conversation
|
@miq add_label react |
|
@miq-bot add_label react |
|
It works for me, in the latest master, I haven't found any issue. 👍 from me. |
|
This pull request is not mergeable. Please rebase and repush. |
Hyperkid123
force-pushed
the
replace-service-form
branch
from
833cd2c
to
dd50170
Compare
might remove this commit if the other PR will be merged before.
Hyperkid123
force-pushed
the
replace-service-form
branch
from
dd50170
to
8c55444
Compare
|
@miq-bot remove_label unmergeable |
Hyperkid123
force-pushed
the
replace-service-form
branch
from
8c55444
to
a049c5f
Compare
|
Checked commits Hyperkid123/manageiq-ui-classic@9df0675~...a049c5f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Tested, all works good! |
| import FormRender from '@data-driven-forms/react-form-renderer'; | ||
| import ServiceForm from '../../components/service-form'; | ||
|
|
||
| describe('Cloud tenant form component', () => { |
There was a problem hiding this comment.
Cloud tenant != Service
EDIT: fixed in #5018
|
|
||
| beforeEach(() => { | ||
| initialProps = { | ||
| maxNameLen: 1, |
There was a problem hiding this comment.
Submit can't ever be undisabled when validation fails, right?
This needs to be at least "foo".length
EDIT: fixed in #5018
| // change form state to enable reset button | ||
| wrapper.find(FormRender).childAt(0).instance().form.change('name', 'foo'); | ||
| wrapper.find(FormRender).childAt(0).instance().form.change('description', 'bar'); | ||
| wrapper.find('button').at(0).simulate('click'); |
There was a problem hiding this comment.
It's still disabled, MiqFormRenderer is using disableSubmit
(probably fixed in #5018)
Replaced angular form with react using data-driven-forms.
form is at:
Services->My Services-> Pick some service ->Configuration->EditChanges
Before
After