Replaces angular ownership form with data-driven-form #5046
Conversation
Tests were failing if you tried to mount component which is setting state outside class constructor.
| %strong | ||
| = _('Note: Some items might be hidden due to the possibility of an ownership change') | ||
|
|
||
| - unless @explorer |
There was a problem hiding this comment.
x edit buttons angular should no longer be needed :)
| = _('Note: Some items might be hidden due to the possibility of an ownership change') | ||
|
|
||
| - unless @explorer | ||
| = render :partial => "layouts/angular/x_edit_buttons_angular" | ||
|
|
||
| - if @ownershipitems | ||
| - @embedded = true | ||
| - @quadicon_no_url = true | ||
| - @gtl_type = settings(:views, :tagging) | ||
| = render :partial => "layouts/gtl" |
There was a problem hiding this comment.
render :partial => "layouts/gtl", :locals => {:no_flash_div => true}
Hyperkid123
force-pushed
the
set-ownership-form
branch
from
21389b8
to
30db930
Compare
| } | ||
|
|
||
| loadInitialData = objectIds => | ||
| http.post('/service/ownership_form_fields', { object_ids: objectIds }) |
There was a problem hiding this comment.
Sorry, all those /service/.. are wrong :(. (also goes for cancelUrl and submitUrl)
We need to be using the current controller, otherwise this fails for all the screens changing ownership for non-services.
Looks like the code is expecting the controller to be one of:
when "orchestration_stack"
when "service"
when "vm_or_template", "vm_infra", "vm_cloud", "vm"
when "miq_template"
(get_class_from_controller_param)
There was a problem hiding this comment.
You can use /${ManageIQ.controller}/ownership_form_fields if it helps.
|
Checked commits Hyperkid123/manageiq-ui-classic@f412d11~...376e4e5 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Changing both user & group for a single item 👍 Changing just user for mulitple items 👎 - resets group ... but turns out those 2 are a separate bug, introduced by #1578, fixing separately. (#5064) |
|
Causes travis failures: Fixed in #5065 |
Continuing migrating to React forms.
This time it is ownership form.
It is located at
Services->My Services-> select some service ->Set Ownership.