feat(layout): makes PF3 forms vertical #6
Conversation
|
First of all, 1)Text boxes 👍 Title text Title text |
@terezanovotna how do we deal with single checkbox? right now its like this: |
|
@terezanovotna thanks for answering! 🏆 One more thing: what about checkboxes which have only one text? 😕 edit: Oh, I see Martin is faster! 🚤 |
|
that's right. I would switch an order. Title (if there is one) |
Hyperkid123
force-pushed
the
master
branch
3 times, most recently
from
445d855
to
1bc6027
Compare
rvsia
force-pushed
the
vertical-form
branch
2 times, most recently
from
1f666db
to
a82d155
Compare
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 86.31% 86.31%
=======================================
Files 63 63
Lines 1030 1030
=======================================
Hits 889 889
Misses 141 141 |
Changes in ManageIQBefore screenshots could be found in PRs:
@terezanovotna @martinpovolny @Hyperkid123 The only ugly change is in the Import/Export form, where it could be fix by just setting a different column size of the text. |
|
@rvsia you want the label to be multi line? Edit: oh never mind. We can fix the alignment in MIQ directly and align it to the left. That is probably correct place right? @terezanovotna |
|
not sure I understand @rvsia. Are you talking about this export and import? If so, I would make these buttons. with the text that's in the explanation. thoughts? |
|
@terezanovotna No, about this text:
It is now aligned to match horizontal inputs and I just wanted to say that it is easy to align it to the left side, so you should not worry about that. 😃 |
|
@miq-bot add_label ux/approved |
rvsia
changed the title
|
@Hyperkid123 please review 🤙 |
|
@rvsia travis is dead |
|
@rvsia travis died again |
|
@Hyperkid123 Should be OK now, dependencies are changing too fast! 🐎 |
|
Please, ping also @epwinchell in these design and UX related PRs and discussions. |
Description
Makes all form vertical by default.
COLcomponentWIP because design is not clear.
Before
After
@terezanovotna How should switch/checkboxes/radios look in a vertical form?
cc @martinpovolny @Hyperkid123