Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename WebsocketWorker to RemoteConsoleWorker #5136

Merged
merged 1 commit into from Jan 14, 2019

Conversation

skateman
Copy link
Member

@skateman skateman commented Jan 8, 2019

Parent issue: ManageIQ/manageiq#18300
Core PR: ManageIQ/manageiq#18337
Schema: ManageIQ/manageiq-schema#319

@miq-bot add_label hammer/no, pending core

@miq-bot
Copy link
Member

miq-bot commented Jan 8, 2019

Checked commit skateman@ed5691b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@skateman skateman changed the title [WIP] Rename WebsocketWorker to RemoteConsoleWorker Rename WebsocketWorker to RemoteConsoleWorker Jan 9, 2019
@miq-bot miq-bot removed the wip label Jan 9, 2019
@mzazrivec mzazrivec self-assigned this Jan 14, 2019
@mzazrivec mzazrivec added this to the Sprint 103 Ending Jan 21, 2019 milestone Jan 14, 2019
@mzazrivec mzazrivec merged commit 4a75962 into ManageIQ:master Jan 14, 2019
@skateman skateman deleted the websocket-to-remote-console branch January 14, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants