Rename WebsocketWorker to RemoteConsoleWorker #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2019
👍 See: #320 It's fine to just remove the worker rows on upgrade to the version where you renamed the class. |
skateman
force-pushed
the
websocket-to-remote-console
branch
from
cfba091
to
0c347a4
Compare
jrafanie
reviewed
Jan 8, 2019
spec/migrations/20190108135546_rename_websocket_to_remote_console_spec.rb
Show resolved
Hide resolved
skateman
force-pushed
the
websocket-to-remote-console
branch
3 times, most recently
from
cec251a
to
4221247
Compare
skateman
changed the title
jrafanie
reviewed
Jan 9, 2019
|
|
||
| say_with_time("Renaming all websocket_worker related SettingsChange keys to remote_console_worker") do | ||
| SettingsChange.where("key LIKE '/workers/worker_base/websocket_worker/%'").select('id, key').each do |row| | ||
| SettingsChange.where(:id => row.id).update(:key => row.key.sub('websocket_worker', 'remote_console_worker')) |
There was a problem hiding this comment.
Can't we do this without this second where? We already have the row. Can we remove the .select on line 24 and perform the update on the row?
There was a problem hiding this comment.
Oh yes 😆 I was thinking too much in SQL 😅
jrafanie
reviewed
Jan 9, 2019
|
|
||
| say_with_time("Renaming all websocket server role SettingsChange records to remote_console") do | ||
| SettingsChange.where("key = '/server/role' AND value LIKE '%websocket%'").select('id', 'value').each do |row| | ||
| SettingsChange.where(:id => row.id).update(:value => row.value.sub('websocket', 'remote_console')) |
jrafanie
reviewed
Jan 9, 2019
|
|
||
| say_with_time("Renaming all remote_console_worker related SettingsChange keys to websocket_worker") do | ||
| SettingsChange.where("key LIKE '/workers/worker_base/remote_console_worker/%'").select('id, key').each do |row| | ||
| SettingsChange.where(:id => row.id).update(:key => row.key.sub('remote_console_worker', 'websocket_worker')) |
jrafanie
reviewed
Jan 9, 2019
|
|
||
| say_with_time("Renaming all remote_console server role SettingsChange records to websocket") do | ||
| SettingsChange.where("key = '/server/role' AND value LIKE '%remote_console%'").select('id', 'value').each do |row| | ||
| SettingsChange.where(:id => row.id).update(:value => row.value.sub('remote_console', 'websocket')) |
|
This looks like a great approach! I had a few questions above. |
skateman
force-pushed
the
websocket-to-remote-console
branch
from
4221247
to
727fa14
Compare
lpichler
reviewed
Jan 10, 2019
| class SettingsChange < ActiveRecord::Base; end | ||
|
|
||
| class ServerRole < ActiveRecord::Base | ||
| self.inheritance_column = :_type_disabled |
There was a problem hiding this comment.
only if there is type column on the model #4 (comment)
skateman
force-pushed
the
websocket-to-remote-console
branch
from
727fa14
to
d800f22
Compare
skateman
force-pushed
the
websocket-to-remote-console
branch
from
d800f22
to
971f43d
Compare
|
Checked commit skateman@971f43d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
approved these changes
Jan 10, 2019
bdunne
approved these changes
Jan 14, 2019
|
🎉 🏃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming both the role and the worker, dropping old workers from the DB.
Parent issue: ManageIQ/manageiq#18300
Core PR: ManageIQ/manageiq#18337
@miq-bot add_label hammer/no